188618 - Get rid of nsITextFrame

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P1)

Description

[Simon Montagu :smontagu]

email from Chris Waterson:

Just noticed that text frame needs to implement nsITextFrame for bidi. That adds
an extra word of overhead for each text frame, which would be nice to avoid. Any
chance we could figure out how to do bidi _without_ the extra interface?
Personally, I'm okay with promoting required methods up to nsIFrame, and just
stubbing them in nsFrame.

Comment 1

[Simon Montagu :smontagu]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 113149 [details] [diff] [review]
Patch

why have the pure virtuals on nsIFrame?  Just put the NS_ERROR_NOT_IMPLEMENTED
up there.... (or, since you never check the retval make it a virtual void)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 113149 [details] [diff] [review]
Patch

Please make the methods 'virtual void' (COM bad!), move the implementions to
nsIFrame and make them empty, and add comments to explain what they do. The
rest looks good.

r+sr=roc+moz

When my nsIFrame deCOMtamination lands, I'll want to change the offsets to be a
reference to an nsContentRange and I'll probably rename the methods too. But
don't worry about that for now.

Comment 4

[Simon Montagu :smontagu]

Attachment: Patch v.2 with changes requested by roc

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc

Transferring r+sr=roc+moz and requesting approval. This is a footprint win with
no semantic change, so risk is minimal.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc

Please hold this cleanup until we open for 1.4alpha. Thanks.

Comment 7

[Simon Montagu :smontagu]

Fix checked in.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: remove nsTextFrame::QueryInterface too

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too

r+sr=bzbarsky

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too

Checked in, 2003-09-16 15:04 -0700.