Closed Bug 188618 Opened 22 years ago Closed 21 years ago

Get rid of nsITextFrame

Categories

(Core :: Layout: Text and Fonts, defect, P1)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
mozilla1.4alpha

People

(Reporter: smontagu, Unassigned)

References

()

Details

(Keywords: memory-footprint)

Attachments

(2 files, 1 obsolete file)

email from Chris Waterson:

Just noticed that text frame needs to implement nsITextFrame for bidi. That adds
an extra word of overhead for each text frame, which would be nice to avoid. Any
chance we could figure out how to do bidi _without_ the extra interface?
Personally, I'm okay with promoting required methods up to nsIFrame, and just
stubbing them in nsFrame.
Keywords: footprint
Priority: -- → P1
Target Milestone: --- → Future
Attached patch Patch (obsolete) — Splinter Review
Attachment #113149 - Flags: superreview?(roc+moz)
Attachment #113149 - Flags: review?(sfraser)
Comment on attachment 113149 [details] [diff] [review]
Patch

why have the pure virtuals on nsIFrame?  Just put the NS_ERROR_NOT_IMPLEMENTED
up there.... (or, since you never check the retval make it a virtual void)
Comment on attachment 113149 [details] [diff] [review]
Patch

Please make the methods 'virtual void' (COM bad!), move the implementions to
nsIFrame and make them empty, and add comments to explain what they do. The
rest looks good.

r+sr=roc+moz

When my nsIFrame deCOMtamination lands, I'll want to change the offsets to be a
reference to an nsContentRange and I'll probably rename the methods too. But
don't worry about that for now.
Attachment #113149 - Flags: superreview?(roc+moz)
Attachment #113149 - Flags: superreview+
Attachment #113149 - Flags: review?(sfraser)
Attachment #113149 - Flags: review+
Attachment #113149 - Attachment is obsolete: true
Comment on attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc

Transferring r+sr=roc+moz and requesting approval. This is a footprint win with
no semantic change, so risk is minimal.
Attachment #113210 - Flags: superreview+
Attachment #113210 - Flags: review+
Attachment #113210 - Flags: approval1.3b?
Comment on attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc

Please hold this cleanup until we open for 1.4alpha. Thanks.
Attachment #113210 - Flags: approval1.3b? → approval1.3b-
Target Milestone: Future → mozilla1.4alpha
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Attachment #131569 - Flags: superreview?(bz-vacation)
Attachment #131569 - Flags: review?(bz-vacation)
Comment on attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too

r+sr=bzbarsky
Attachment #131569 - Flags: superreview?(bz-vacation)
Attachment #131569 - Flags: superreview+
Attachment #131569 - Flags: review?(bz-vacation)
Attachment #131569 - Flags: review+
Comment on attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too

Checked in, 2003-09-16 15:04 -0700.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: