188877 - [FIX]Progress Dialog download crash -Trunk [@ nsXPCWrappedJS::GetInterfaceInfo]

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Max Alekseyev]

OS/2 build 2003011212

To reproduce:
1. Turn on Edit->Preferences->Navigator->Downloads->"Open a Progress Dialog"
2. Open provided URL
3. RMB click on "Load Large Graphic: 496,142 bytes" link
4. Choose "Save Target As...", select location to download, and click OK
5. Mozilla crashes when downloading finished

------------------------------------------------------------

01-13-2003  03:34:20  SYS3175  PID 0054  TID 0001  Slot 006d
O:\INTERNET\MOZILLA\MOZILLA.EXE
c0000005
d03707cf
P1=00000001  P2=d03707cf  P3=XXXXXXXX  P4=XXXXXXXX  
EAX=0ae475f0  EBX=0ae47980  ECX=0ae22648  EDX=00000000
ESI=018a9ab0  EDI=001317a8  
DS=0053  DSACC=f0f3  DSLIM=ffffffff  
ES=0053  ESACC=f0f3  ESLIM=ffffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:d03707cf  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:0013172c  SSACC=f0f3  SSLIM=ffffffff
EBP=00131848  FLG=00212206

Comment 1

[Boris Zbarsky [:bzbarsky]]

seeing this on Linux too...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: patch....

Don't want to access members after we have been destroyed, no sirree.

Comment 3

[jag (Peter Annema)]

Comment on attachment 111400 [details] [diff] [review]
patch....

Isn't that a rather complicated way of writing

nsCOMPtr<nsIDownload> kungFuDeathGrip(do_QueryInterface(this));

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111400 [details] [diff] [review]
patch....

"this" has ambiguous inheritance from nsISupports; see bug 181387

Comment 5

[Boris Zbarsky [:bzbarsky]]

ccing jag so's he can actually read answers to his questions.  ;)

Comment 6

[jag (Peter Annema)]

Comment on attachment 111400 [details] [diff] [review]
patch....

Ugh. Comment and reference to bug 181387 then? Otherwise it's bound to get
"cleaned up".

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111400 [details] [diff] [review]
patch....

Um, I can add a comment, sure.	But attempts to "clean it up" won't compile, so
I have my doubts that it will happen.  ;)

Comment 8

[jag (Peter Annema)]

Comment on attachment 111400 [details] [diff] [review]
patch....

Then at least you'll prevent attempts to clean it up (and thus time wasted).

Comment 9

[Boris Zbarsky [:bzbarsky]]

fixed.

Comment 10

[David Bradley]

*** Bug 188964 has been marked as a duplicate of this bug. ***

Comment 11

[Chris Petersen]

Verified on the Win32 2003-01-15-08 trunk build (2003-01-15-08) and Mac OS X CFM
Trunk (2003-01-15-08).

Comment 12

[Jay Patel [:jay]]

Adding topcrash keyword and Trunk [@ nsXPCWrappedJS::GetInterfaceInfo] from
duped bug 188964.  No crashes reported after 1/13 builds.