189097 - "You have joined"-line should mention nick too

Status: VERIFIED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[Jo Hermans]

When you join a channel in Chatzilla, you get greeted with a line like "YOU have
joined #mozilla". But it isn't clear who has joing the channel. Yes, the nick is
visible at the left-bottom, in front of the input-line, but it could be clearer.
What about smtg like "YOU (nick) have joined #mozilla" ?

build 2003011408 on Mac OS 9.2.2

Comment 1

[Samuel Sieb]

Your nick is the same on all channels of the same server.  It is prominently
displayed in the titlebar.

Comment 2

[:Gijs (he/him)]

(In reply to comment #1)
> Your nick is the same on all channels of the same server.  It is prominently
> displayed in the titlebar.

So, this could be marked WONTFIX, correct?

Comment 3

[Jo Hermans]

(In reply to comment #2)
> (In reply to comment #1)
> > Your nick is the same on all channels of the same server.  It is prominently
> > displayed in the titlebar.
> 
> So, this could be marked WONTFIX, correct?
> 

I wanted to mention the nick inside the "You have joined #mozilla" line. If it's
decided to be WONTFIX'ed, ok. But I don't see what anybody has against a line
like "You ($nick) have joined $channel".

Comment 4

[James Ross]

What about the various other messages that use "YOU"? Do you think they should
also show your nickname?

Comment 5

[Jo Hermans]

I don't think that's necessary, but it's possible.

Comment 6

[:Gijs (he/him)]

Attachment: patch to change all 'YOU' messages

Patch that changes the message for the line where you join, as well as those
for leaving, being kicked, and quitting (which I can't test ;-))

Comment 7

[:Gijs (he/him)]

Re-adding rginda to the CC list...

Comment 8

[Robert Ginda]

Comment on attachment 177588 [details] [diff] [review]
patch to change all 'YOU' messages

r=rginda

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 177588 [details] [diff] [review]
patch to change all 'YOU' messages

a=asa

Comment 10

[James Ross]

Checked in --> FIXED.

Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will
include this shortly.

Comment 11

[Jo Hermans]

verified as fixed in Chatzilla 0.9.68a (dated april 16th)