189183 - Debugger source frame window layering fix

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Marcus Crafter]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9

When using jdk 1.4.1 on linux, the Rhino debugger doesn't automatically focus
the internal frames when tracing through applications spread across multiple
sources. 

When tracing through an application that uses multiple sources, the currently
active window isn't brought to the front. Tracing succeeds, but the user needs
to manually go through the 'window' menu item to make the active internal frame
visible.

After speaking with Christopher Oliver, it seems this problem is only apparent
with JDK 1.4.1

Reproducible: Always

Steps to Reproduce:
1. debug application that uses multiple source files
2. trace through function that invokes a method in another source file
Actual Results:  
Observed that the trace succeeds but the internal frame window isn't modified.

Expected Results:  
The source file windows should be automatically focused when tracing between them.

Christopher Oliver sent me a fix which I tested, I'll attach a patch after
submitting this form.

Comment 1

[Marcus Crafter]

Attachment: Patch to fix internal frame layering under jdk 1.4.1

Comment 2

[Phil Schwartau]

cc'ing Igor -

Comment 3

[Igor Bukanov]

Marcus, could you check that with your fix everything is OK under JDK 1.3 as well?

Comment 4

[Marcus Crafter]

Hi Igor, testing with JDK 1.3.1 (under Linux) looks good.

Cheers, Marcus

Comment 5

[Igor Bukanov]

Attachment: Single file testcase for debugger

The test case uses Function and eval to make debugger to show several windows.
To test, select "Break on function enter" in the Debug menu and press GO
several time.

Comment 6

[Igor Bukanov]

I commited Christopher Oliver's patch, the bug can be market as fixed.

Comment 7

[Igor Bukanov]

Marcus, you could mark as it fixed as long the fix is in CVS and you can see
that is works. I could not mark it because I am not a bug owner or reporter. The
verified status then should set somebody else.

Comment 8

[Phil Schwartau]

Using JDK 1.4.1-b21 on WinNT.

Marking FIXED. I see the change in CVS and have tried the
testcase Igor provided in Comment #5, with good results -

Comment 9

[Phil Schwartau]

Marking Verified Fixed.

When I follow the steps Igor gave in Comment #5, I see the
new debugger windows being created, and the most recent one,
corresponding to the active frame, gets put on top as desired -

Comment 10

[Igor Bukanov]

Targeting as resolved against 1.5R4