189430 - In <chrome://messenger/content/msgMail3PaneWindow.js>, "Warning: reference to undefined property window.arguments[2]"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Henrik Gemal]

Warning: reference to undefined property window.arguments[2]
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 634

seems to happen when you double click on a newsgroup server so that you have two
open mail windows

20030116

Comment 1

[Serge Gautherie (:sgautherie)]

Could you check with a recent version, like v1.4rc3 ?

Comment 2

[Steve Chapel]

I can reproduce with build 2003082004, although double-clicking does not open
two windows.

Comment 3

[Steve Chapel]

Attachment: (Av1) <msgMail3PaneWindow.js>

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

Re comment 2:

Confirmed:
It happens on 'Open in New Mail Window' (double click / context menu / ...),
whether the folder is newsgroup / pop3 / ...;
I believe the reporter meant '2 = initial window + new window' ;->

Line number changed:
{
Warning: reference to undefined property window.arguments[2]
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 650
}

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 138047 [details] [diff] [review]
(Av1) <msgMail3PaneWindow.js>


That's the idea, but
Allow me to rewrite it some more.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 138047 [details] [diff] [review]
(Av1) <msgMail3PaneWindow.js>

>+    gStartMsgKey = [1] in window.arguments ? window.arguments[1] : null;

(for the record)
It seems that |gStartMsgKey| should not be |null|.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <msgMail3PaneWindow.js>

Test successful (after deleting XUL.mfl).

Comment 8

[[e-mail]]

Comment on attachment 139577 [details] [diff] [review]
(Av2) <msgMail3PaneWindow.js>

I think you should be checking window.arguments.length instead.

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Av3) <msgMail3PaneWindow.js> (== Av2 :-()

Av2, with comment 8 suggestion(s).

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Av3b) <msgMail3PaneWindow.js>

Av3 with correct file :->

Comment 11

[[e-mail]]

Comment on attachment 139627 [details] [diff] [review]
(Av3b) <msgMail3PaneWindow.js>

Would you mind using .length for all three cases? Also, please make the : line
up with the ?

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Av4) <msgMail3PaneWindow.js> [Checked in: Comment 13]

Av3b, with comment 11 suggestion(s).

I was keeping [0] from the current code...
I forgot to update the line up from Av2 -> Av3b :-(

Comment 13

[[e-mail]]

Fix checked in.