189545 - pk11_Finalize may fail if 'count' is larger than 256

Status: RESOLVED DUPLICATE of bug 189345

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

In lib/pk11wrap/pk11skey.c, function pk11_Finalize, there
is a stack buffer 'char stackBuf[256]' that is passed to
the various C_XxxFinal functions. But we simply fail if
the 'count' returned by the first C_XxxFinal call (with
a NULL buffer) is larger than 256.  We should allocate
a buffer if 'count' is > 256.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

I am relying on the fact that passing a NULL
to PORT_Free is a no-op.  If you don't like
that, I can change it to:
    if (buffer != NULL && buffer != stackBuf) {
	PORT_Free(buffer);
    }

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch v2

Sorry, the previous patch contains some other
changes that don't pertain to this bug.

Comment 3

[Wan-Teh Chang]

I decided to just fix this problem as part of bug 189345.

*** This bug has been marked as a duplicate of 189345 ***