189682 - localize time units

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Robert Kaiser]

In utils.js, you can find the formatDateOffset function:
http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/utils.js#378

The units "days", "hours", "minutes", and "seconds" are hardcoded there, and not
localizeable. They should move into a .properties file instead...

Comment 1

[Robert Ginda]

Those are just the default values.  If the code using this function cares about
localization it should use the |format| parameter, as ChatZilla does.

Comment 2

[Robert Kaiser]

rginda: the problem is that I got reports of people who got unlocalized
"sencods" strings in Chatzilla, though I've localized all occurrencies chatzilla
has in it's locale files...

I thought it would be this causing it - well, it seems I have to dig a bit
deeper, right?

Comment 3

[Robert Ginda]

Oops, my bad.  After actually grpping the ChatZilla source, it looks like the
callsites were never modified.  I'm sure I had every intention of fixing this at
some point :)

handlers.js:        var connectTime = formatDateOffset (Math.floor((new Date() -
handlers.js:            formatDateOffset (Math.floor((new Date() - s.lastPing) /
1000)) :
handlers.js:                          [nick, formatDateOffset(Number(e.params[3])),
handlers.js:    var delay = formatDateOffset ((new Date() - new
Date(Number(e.CTCPData))) /

Comment 4

[Koike Kazuhiko]

Attachment: patch v1

Comment 5

[Robert Ginda]

Comment on attachment 118695 [details] [diff] [review]
patch v1

r=rginda

Comment 6

[Samuel Sieb]

checked in