189982 - automatic image resizing: state of the image should be kept after resizing the browser window

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, enhancement, P5)

Description

[Benjamin]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Q312461; .NET CLR 1.1.4322)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030121

the state of the image shouldn't change after resizing the browser window, ie 
if the image was restored to full size before resizing it shouldn't shrink back 
to the new size of the window but stay in full size.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Benjamin]

Attachment: patch

this patch achieves the suggested behaviour

Comment 2

[Boris Zbarsky [:bzbarsky]]

To jan

Comment 3

[Jan Varga [:janv]]

Attachment: patch2

I already wanted to do this, but instead of additional boolean variable I
changed mImageIsResized to mImageState.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

why not make mImageState an enum? gives more friendly names in debuggers...

Comment 5

[Brian 'netdragon' Bober]

Will include in patch for bug 73322

Comment 6

[Brian 'netdragon' Bober]

Scratch that. The patch in this bug will be building off the one in bug 190545
when its checked in.

Comment 7

[Brian 'netdragon' Bober]

Comment on attachment 112205 [details] [diff] [review]
patch2

Actually, they will all be just included in the same patch.

Comment 8

[Brian 'netdragon' Bober]

Oops, sorry about the incorrect setting. Sorry about all the SPAM. The problem 
is that I can't change some bug settings at the same time as others.

Comment 9

[jag (Peter Annema)]

Erh... Is that last patch truly obsolete?

Comment 10

[Brian 'netdragon' Bober]

Jan recommended that we just include this patch in the patch on bug 190545
(which is about to be revised) since bug 190545 has some changes to the
underlying code this patch fixes.

Comment 11

[Jan Varga [:janv]]

Attachment: new patch

now with an enum :)

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 120998 [details] [diff] [review]
new patch

Hm... this does not do the right thing completely... 

If I enable automatic image resizing, and load say http://www.mozilla.org/ and
make my browser window smaller than the image, larger than the image and then
again smaller, the image is still shown in its original size and not resized.
this works without the patch.

Comment 13

[Jan Varga [:janv]]

Comment on attachment 120998 [details] [diff] [review]
new patch

ok, this needs a completely different approach

Comment 14

[Brian 'netdragon' Bober]

I'm still working on bug 190545, and this issue is still fixed in my latest code
for that bug (the current patch as of writing this is obsolete).

Comment 15

[Jim Dunn]

*** Bug 203174 has been marked as a duplicate of this bug. ***

Comment 16

[Samir Gehani]

adt: nsbeta1-

Comment 17

[Alfonso Martinez]

*** Bug 203146 has been marked as a duplicate of this bug. ***

Comment 18

[Asa Dotzler [:asa]]

*** Bug 210359 has been marked as a duplicate of this bug. ***

Comment 19

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I don't understand comment 12, but I think I can do something reasonable.

Comment 20

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

With this patch, resizing the window does not toggle scaling (if it was scaled
before, it continues to be scaled, and if it wasn't, it stays full size until
you click).

Comment 21

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 178979 [details] [diff] [review]
patch

>Index: content/html/document/src/nsImageDocument.cpp
>   PRPackedBool                  mImageIsResized;
>+  PRPackedBool                  mShouldResize;

Please document how the latter differs from the former, ok?

>+  PRBool wasResized = mImageIsResized;

That var looks unused.	Take that out?

With that, r=bzbarsky

Comment 22

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

checked in

Comment 23

[Benjamin]

Verified that this Bug is fixed.
Version: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050409 Firefox/1.0+

Comment 24

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

*** Bug 252437 has been marked as a duplicate of this bug. ***