190247 - Pippki.* files should not be part of GRE package

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Sean Su]

-- comment from [e-mail] ---
 First off, you do not need pippki.* files in the case of embedding(or the GRE).
 Please see http://bugzilla.mozilla.org/show_bug.cgi?id=166945
 If Mozilla needs these files, then we should be modifying Mozilla's installer
 manifest files rather than embedding manifest files i.e. basebrowser-win.

 Same thing with pipnss.jar - Mozilla's installer manifest files should be
 modified instead of basebrowser-win.
--

Comment 1

[Quinn Yost (mythdraug)]

Could this be causing bug 190245?

Comment 2

[Sean Su]

Attachment: patch v1.0

Comment 3

[Sean Su]

Comment on attachment 112420 [details] [diff] [review]
patch v1.0

just tested this patch with twalker.  it does fix bug 190151.

Comment 4

[Sean Su]

Attachment: patch v1.0 (ns tree)

this is the same fix as above, but for the ns tree.

Comment 5

[Chak Nanga]

Comment on attachment 112420 [details] [diff] [review]
patch v1.0

Sean, looks good to me...thanks

r=chak

Comment 6

[Chak Nanga]

Comment on attachment 112428 [details] [diff] [review]
patch v1.0 (ns tree)

r=chak

Comment 7

[Sean Su]

both patches checked in.  marking this bug fixed.

Comment 8

[Charles Rosendahl]

I need to ask this question - are the pippki.* files part of the same package
that includes support for the nss and ssl libraries?

I have noticed random behavior on my system at times that prevents ssl from
working (both in gre-mozilla and gre-mfcembed) as have now a few others have in
the latest gre-mozilla builds.

I just want to make sure that we aren't removing anything from the GRE package
that might cause breakage trying to use encryption functionality.

Comment 9

[Charles Rosendahl]

Verified on the GRE side (also in themozilla client) - just passing on to Grace
for final verification on the mozilla side.

Comment 10

[Charles Rosendahl]

Verified