190281 - Focus doesn't skip disabled inputs properly

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Load the URL
2. TAB to the first input and type some text
3. Press TAB twice

Expected results: First TAB takes you to third input

Actual results: Second TAB takes you to third input

Additional information: The first TAB selects the text as if I just focused it

Comment 1

[Boris Zbarsky [:bzbarsky]]

happens on Linux too.

Comment 2

[sairuh (rarely reading bugmail)]

i also see this in the preference panes, eg, where there are textfields
associated with a checkbox:

Advanced
Advanced - Mouse Wheel
Offline & Disk Space
P&S - Cookies

neil, do you remember when this last worked? (a general time period is okay
--just want to know how far back to go in order to narrow the bug down.)

Comment 3

[[e-mail]]

I had to tweak my patch in bug 82547 because of this bug, so I am reasonably
confident that the regression occurred after the patch dated 2002-09-20.

Comment 4

[sairuh (rarely reading bugmail)]

this regressed sometime btwn the 9/18 (works fine) and 9/24 (broken) builds.
note: the intermediary builds (tested 9/19, 9/23) were broken (could not tab
within Prefs).

Comment 5

[[e-mail]]

Attachment: Make mozilla ignore disabled elements

Does this mean we can get rid of lots of disabled attribute checks?

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 115857 [details] [diff] [review]
Make mozilla ignore disabled elements

I'm no expert in our CSS extensions, but this looks reasonable to me.

Comment 7

[Boris Zbarsky [:bzbarsky]]

This needs review by aaronl; with jst being the sr, I guess...

And yes, there are places in the event state manager that could maybe skip
attribute checks now; again, check with aaronl.

Comment 8

[Samir Gehani]

adt: nsbeta1+/adt3

Comment 9

[Aaron Leventhal]

Comment on attachment 115857 [details] [diff] [review]
Make mozilla ignore disabled elements

r=aaronl

Comment 10

[[e-mail]]

Comment on attachment 115857 [details] [diff] [review]
Make mozilla ignore disabled elements

This low-risk patch ensures that disabled really means disabled.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 115857 [details] [diff] [review]
Make mozilla ignore disabled elements

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 12

[[e-mail]]

Fix checked in.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Hey, _can_ we now eliminate those disabled attr checks in the ESM?

Comment 14

[sairuh (rarely reading bugmail)]

except for a very minor issue (see bug 205576), this bug is fixed.

vrfy'd with 2003.05.13 comm builds.