190555 - Weird find as you type behavior on this msdn page

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Aaron Leventhal]

Go to:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/xmlsdk/htm/xml_mth_sz_0z1h.asp?frame=true&hidetoc=true

Type /encoding to do a text search for encoding.

Everytime you hit the next character, find as you type starts over, but only if
the last stopping point was a link.

Anyone care to try to narrow this down to a smaller testcase?

Comment 1

[Aaron Leventhal]

I think this is fixed in recent builds.

Comment 2

[sairuh (rarely reading bugmail)]

i cannot seem to repro using 2003.01.27.10 trunk bits on linux rh7.2. marking
w4m, but reopen if still a problem in a recent build.

Comment 3

[Aaron Leventhal]

Johnny points out that if you type all/encoding the bug still happens.

all does a link search
/encoding wakes up the text search, which exhibits the strange behavior of
selecting 1 char at a time.

Comment 4

[Aaron Leventhal]

Attachment: Simple patch, I was accidentally resetting mFocusedWIndow to the incorrect value. It should always be the top content window.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 113444 [details] [diff] [review]
Simple patch, I was accidentally resetting mFocusedWIndow to the incorrect value. It should always be the top content window.

sr=jst

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 113444 [details] [diff] [review]
Simple patch, I was accidentally resetting mFocusedWIndow to the incorrect value. It should always be the top content window.

>-  GetAutoStart(startWindow, &isAutoStartWin);
>+  GetAutoStart(mFocusedWindow, &isAutoStartWin);

Do you still need the nsIDOMNode* parameter to GetAutoStart?  It is only called
twice, and in both places the parameter is mFocusedWindow after your change. 
I'd wager that you don't need the nsIDOMNode* parameter to SetAutoStart either
(or possibly the whole method since nobody seems to ever call SetAutoStart...)

r=caillon with the above addressed.

Comment 7

[Aaron Leventhal]

Chirsotpher, I want to keep the nsIDOMWindow parameter in GetAutoStart, because
it's part of the nsITypeAheadFind interface, and that method can be used by
other typeaheadfind-aware modules.

Comment 8

[Aaron Leventhal]

checked in

Comment 9

[guanxi]

*** Bug 193159 has been marked as a duplicate of this bug. ***

Comment 10

[Aaron Leventhal]

*** Bug 193291 has been marked as a duplicate of this bug. ***

Comment 11

[sairuh (rarely reading bugmail)]

seems to work for me, using 2003.02.18 comm trunk on win2k.

Comment 12

[Aaron Leventhal]

*** Bug 195345 has been marked as a duplicate of this bug. ***

Comment 13

[Aaron Leventhal]

*** Bug 196034 has been marked as a duplicate of this bug. ***

Comment 14

[Aaron Leventhal]

*** Bug 197100 has been marked as a duplicate of this bug. ***