190638 - JavaScript warnings and errors in Profile Manager

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Brant Gurganus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030125
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030125

I ran the Profile Manager from within Mozilla and it gave some warnings.

Reproducible: Didn't try

Steps to Reproduce:
1. Run Profile Manager in Tools menu.
Actual Results:  
Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://communicator/content/profile/createProfileWizard.js
Line: 35
Source Code:
}

Warning: function Startup does not always return a value
Source File: chrome://communicator/content/profile/createProfileWizard.js
Line: 66
Source Code:
}

Warning: function processCreateProfileData does not always return a value
Source File: chrome://communicator/content/profile/createProfileWizard.js
Line: 176
Source Code:
}

Warning: reference to undefined property this.PageData[tag]
Source File: chrome://global/content/widgetStateManager.js
Line: 437

Warning: reference to undefined property thisTagData.nodata
Source File: chrome://global/content/widgetStateManager.js
Line: 184

Warning: reference to undefined property this.content_frame.onInit
Source File: chrome://global/content/widgetStateManager.js
Line: 279

Warning: reference to undefined property this.content_frame.validate
Source File: chrome://global/content/widgetStateManager.js
Line: 293

Warning: reference to undefined property this.content_frame.GetFields
Source File: chrome://global/content/widgetStateManager.js
Line: 89

Warning: reference to undefined property doc.controls
Source File: chrome://global/content/widgetStateManager.js
Line: 98

Warning: reference to undefined property this.PageData[tag]
Source File: chrome://global/content/widgetStateManager.js
Line: 437

Warning: reference to undefined property thisTagData.nodata
Source File: chrome://global/content/widgetStateManager.js
Line: 184

Warning: reference to undefined property this.content_frame.onInit
Source File: chrome://global/content/widgetStateManager.js
Line: 279

Expected Results:  
No warnings.

I had strict warnings on.

Comment 1

[timeless]

Attachment: fix issues

Comment 2

[Brant Gurganus]

I tried timeless's patch and there is one warning left for that file that I came
across:

Warning: assignment to undeclared variable proceed
Source File: chrome://communicator/content/profile/createProfileWizard.js
Line: 99

And in other files:

Warning: assignment to undeclared variable renameButton
Source File: chrome://communicator/content/profile/profileManager.js
Line: 55

Warning: assignment to undeclared variable deleteButton
Source File: chrome://communicator/content/profile/profileManager.js
Line: 134

Since timeless already fixed the other warnings, I'll fix that uninitialized
variable and try it again next time I restart Mozilla.

Comment 3

[Brant Gurganus]

Attachment: fixes the undeclared variables

I just tested out this patch, the only remaining things are the undefined
properties which I am not so sure how to fix.

Comment 4

[Brant Gurganus]

Comment on attachment 112701 [details] [diff] [review]
fixes the undeclared variables

By the way, the seemingly unchanged lines are because my editor removes
worthless trailing spaces from lines.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Please attach a cvs diff -uw.  Also, I'm not the right person to really review
the patch.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 112701 [details] [diff] [review]
fixes the undeclared variables

Again, please attach a cvs diff -uw

Comment 7

[Brant Gurganus]

Attachment: patch for profileManager.js and createProfileWizard.js

remade patch

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 118202 [details] [diff] [review]
patch for profileManager.js and createProfileWizard.js

Looks good to me, but I really don't qualify to review this code (sorry). 
Since it's profile manager, can you get [e-mail] to take a
gander?  Thanks.

Comment 9

[Matthias Versen [:Matti]]

Comment on attachment 112691 [details] [diff] [review]
fix issues

clearing obsolete review requests

Comment 10

[jag (Peter Annema)]

Comment on attachment 118202 [details] [diff] [review]
patch for profileManager.js and createProfileWizard.js

r=+sr=jag

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 118202 [details] [diff] [review]
patch for profileManager.js and createProfileWizard.js

a=asa (on behalf of drivers) for checkin to 1.4b.

Comment 12

[Brant Gurganus]

I don't have checkin privs if somebody else wants to do it.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in createProfileWizard.js;
/cvsroot/mozilla/profile/resources/content/createProfileWizard.js,v  <-- 
createProfileWizard.js
new revision: 1.41; previous revision: 1.40
done
Checking in profileManager.js;
/cvsroot/mozilla/profile/resources/content/profileManager.js,v  <-- 
profileManager.js
new revision: 1.55; previous revision: 1.54
done