190747 - chatzilla shouldn't open a window until the server sends a JOIN

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Perry Lorier]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021126
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021126

ChatZilla currently opens a window only when a user issues a /join command,
ChatZilla should really only open the window when it recieves a JOIN command
from the server for itself.  This is because the server may send unsolicited
JOINs, or perhaps JOIN's that the IRC client wasn't expecting, eg: /join #[Foo],
and getting back :IRCMonkey JOIN #{foo} instead.

Reproducible: Always

Steps to Reproduce:
1. join a channel
2. note the window opens before the IRC server responds

Actual Results:  
uh, channel window opened before the IRC server responds

Expected Results:  
Mozilla should have waited until the JOIN command came back from the IRC server.
 Optionally displaying a message such as "*** Joining #[Foo]" somewhere to give
the user some feedback that the command is in progress.

I believe that this is important for the ongoing archetectual stability of
Chatzilla. :)

Comment 1

[Koike Kazuhiko]

*** Bug 155831 has been marked as a duplicate of this bug. ***

Comment 2

[Koike Kazuhiko]

Attachment: patch

Comment 3

[Samuel Sieb]

Comment on attachment 117920 [details] [diff] [review]
patch

I think it should be moved inside the userIsMe test.  We don't want a join
message every time someone deletes a tab.

Comment 4

[Robert Ginda]

Comment on attachment 117920 [details] [diff] [review]
patch

what ssieb said.

Comment 5

[Koike Kazuhiko]

Attachment: patch v2

Comment 6

[Samuel Sieb]

checked in