190801 - TestXPTCInvoke violates xpcom for outparams and should pass its char*s as const

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 235: Warning: String literal converted to char* in
initialization.
"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 742: Warning: String literal converted to char* in
initialization.
"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 742: Warning: String literal converted to char* in
initialization.
"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 765: Warning: String literal converted to char* in
initialization.
"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 765: Warning: String literal converted to char* in
initialization.
"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 800: Warning: String literal converted to char* in
initialization.
"/export/home/timeless/mozilla/xpcom/reflect/xptcall/tests/TestXPTCInvoke.cpp",
line 800: Warning: String literal converted to char* in
initialization.

Comment 1

[timeless]

Attachment: fix

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 112762 [details] [diff] [review]
fix

nit - please treat sizeof as a function and use Parenthesis:

+    const char milk[] = "milk";
+    char *ret = (char*)nsMemory::Alloc(sizeof milk);

sizeof milk

okay.

Comment 3

[timeless]

checked in