191150 - accesskeys firing events twice

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[piers]

It appears that accesskeys are firing their events twice (the function they
perform  happens twice). This is a fairly major accessability bug:

To reproduce:
1. Open Edit -> Preferences -> Navigator -> Languages
2. Add a few languages (say 5 to make sure the list is long enough)
3. Select a language and press Alt+U and Alt+D (to move the item up and down)

Actual results: the first time after adding, the accesskey works as expected,
subsequently, the accesskey causes the item to move two places up or down.

Expected: just move one place up or down.

This appears related to bug 37262, but may not be the same. Tested on Windows
and Solaris.

Comment 1

[sairuh (rarely reading bugmail)]

yep, i see this with today's linux build (2003.01.29.08 comm trunk). it seems
"limited" to using xul access keys in dialogs (like prefs), as it doesn't appear
to be a problem using access keys in the menus (no double execution there, afaict).

could this be a recent regression?

Comment 2

[sairuh (rarely reading bugmail)]

this also occurs in 2003.01.28.05 bits.

Comment 3

[piers]

sairuh, surely this is a bug, not an enhancement?

Comment 4

[sairuh (rarely reading bugmail)]

whups, dunno how that field was set. definitely not an rfe. ;)

Comment 5

[Asa Dotzler [:asa]]

aaronl's going to be taking a look at this tomorrow. 

Comment 6

[Aaron Leventhal]

Attachment: Make sure xul:button's unmodified accesskey detection throws away alt/ctrl/meta modified keystrokes

Comment 7

[Aaron Leventhal]

Comment on attachment 113158 [details] [diff] [review]
Make sure xul:button's unmodified accesskey detection throws away alt/ctrl/meta modified keystrokes

Seeking r=/sr= for small 2 line fix

Comment 8

[Samir Gehani]

Comment on attachment 113158 [details] [diff] [review]
Make sure xul:button's unmodified accesskey detection throws away alt/ctrl/meta modified keystrokes

r=sgehani

Comment 9

[jag (Peter Annema)]

Comment on attachment 113158 [details] [diff] [review]
Make sure xul:button's unmodified accesskey detection throws away alt/ctrl/meta modified keystrokes

sr=jag

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 113158 [details] [diff] [review]
Make sure xul:button's unmodified accesskey detection throws away alt/ctrl/meta modified keystrokes

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 11

[Aaron Leventhal]

checked in

Comment 12

[sairuh (rarely reading bugmail)]

looks good --vrfy'd fixed with 2003.02.11.04 comm trunk bits on win2k and linux
rh8.0.