191159 - Use xpt_link on .xpt files in dist/Embed/components

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Packaging, defect)

Description

[Conrad Carlen (not reading bugmail)]

There is a large number of .xpt files in the embedding package. For embedding
apps that need to package up the contents of the embedding package (Chimera,
PPEmbed), it's a pain. Using the following command (leaving as note to self):

conrad% ../../dist/bin/xpt_link ../../dist/Embed/components/linked.xpt
../../dist/Embed/components/*.xpt

the merged file is only 180K. Since it's so small, why don't we just do the
merge by default and make it easier for embeddors?

Comment 1

[Conrad Carlen (not reading bugmail)]

Moving to new bugzilla component.

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: patch to add make merge target

Using this, an embedding app like Camino could just:
cd embedding/config
make && make merge_xpt

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 125116 [details] [diff] [review]
patch to add make merge target

this looks fine.

Comment 4

[Conrad Carlen (not reading bugmail)]

Attachment: patch for Chimera.pbproj to make use of this

All references to ../dist/Embed/components/*.xpt were replaced with one to the
merged file.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 125116 [details] [diff] [review]
patch to add make merge target

r=bryner; maybe merge should happen by default as well?

Comment 6

[Conrad Carlen (not reading bugmail)]

attachment 125116 [details] [diff] [review] checked in. Bryner, it would be nice to have this for Camino.
Move that patch to a separate bug?

The reason the merge doesn't happen by default is that we don't want the merged
file in the same dir as the individual files. Removing them would break any
number of embeddors building apps from this. That should be done, but I'll give
notice on n.p.m.embedding first.