Closed
Bug 191171
Opened 23 years ago
Closed 23 years ago
Move mailnews start page to chrome://
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 2 obsolete files)
|
5.69 KB,
patch
|
neil
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
I (and others) think that's it's bad to load a static page, like the Mozilla
MailNews start page from the web if it could be placed in chrome as well.
The Netscape one's content is dynamic, of course, and therefore it's right to
have it on their website.
This would solve a bunch of issues (along with reducing unneeded traffic on
mozilla.org):
- It would be easy to make it localizable
- It would still be loaded if a users is offline and starts mailnews
- It could be changed to fit specialities of different versions (new functions
that should be listed etc.)
- perhaps a few others
Web traffic can be worth a view here as well, as it seems: I have this page
localized in German Mozilla, and placed it on my own website, and now it causes
over a gig of traffic per month - quite a lot for me, I have to admit...
Because of that, I'll probably place it in chrome anyway in the upcoming
releases, it would be much easier if it would be in chrome:// anyway...
BTW, moving that page into chrome was already discussed a bit in bug 66570, it
seems that issue will need this move as well.
Comment 1•23 years ago
|
||
If we do that, we can't replace the mailnews_start_page with a Hammer photo.
| Assignee | ||
Comment 2•23 years ago
|
||
Matti refers to bug 138724 - as this is closed fixed, it's no issue here. :)
| Assignee | ||
Comment 3•23 years ago
|
||
OK, so here's a patch to get this working. This puts the the start page from
http://www.mozilla.org/mailnews/start.html into en-US.jar and changes
region.properties to use this one.
The page is unchanged from the current version, I only did some whitespace
cleanup.
| Assignee | ||
Updated•23 years ago
|
Attachment #115248 -
Flags: review?(sspitzer)
Comment 5•23 years ago
|
||
Comment on attachment 115248 [details] [diff] [review]
patch v1: add start page to en-US.jar, use that one as default
some of the links in start.html are relative (as the page used to live on
mozilla.org)
Attachment #115248 -
Flags: review?(sspitzer) → review-
| Assignee | ||
Comment 6•23 years ago
|
||
Uh, well, it's easy to miss that. This patch corrects the links.
Attachment #115248 -
Attachment is obsolete: true
| Assignee | ||
Updated•23 years ago
|
Attachment #115287 -
Flags: review?(sspitzer)
Comment 7•23 years ago
|
||
Comment on attachment 115287 [details] [diff] [review]
patch v2: use absolute URLs for links
start.html says mail_mozilla.gif and jar.mn says mozilla_mail.gif :-/
Attachment #115287 -
Flags: review?(sspitzer) → review-
| Assignee | ||
Comment 8•23 years ago
|
||
Neil:
Yes, I know. I already had corrected jar.mn in my local tree because it
complained at build time. Here's the patch covering that change.
Attachment #115287 -
Attachment is obsolete: true
| Assignee | ||
Updated•23 years ago
|
Attachment #118766 -
Flags: review?(neil)
| Assignee | ||
Updated•23 years ago
|
Target Milestone: --- → mozilla1.4beta
Comment 9•23 years ago
|
||
Comment on attachment 118766 [details] [diff] [review]
patch v3: correct filename reference
And you updated for bitrot too I see :-)
Attachment #118766 -
Flags: superreview?(sspitzer)
Attachment #118766 -
Flags: review?(neil)
Attachment #118766 -
Flags: review+
| Assignee | ||
Comment 10•23 years ago
|
||
Yes, I have it applied in my local tree and keep it building with trunk, so I
had to update it with jar.mn changes, and a new cvs diff is against current
trunk of course :)
Comment 11•23 years ago
|
||
Comment on attachment 118766 [details] [diff] [review]
patch v3: correct filename reference
sr=sspitzer, sorry for the delay, robert.
after this lands, we'll fix the start page (this one is so outdated.)
Attachment #118766 -
Flags: superreview?(sspitzer) → superreview+
| Assignee | ||
Comment 12•23 years ago
|
||
RCS file: /cvsroot/mozilla/mailnews/base/resources/locale/en-US/start.html,v
done
Checking in mozilla/mailnews/base/resources/locale/en-US/start.html;
/cvsroot/mozilla/mailnews/base/resources/locale/en-US/start.html,v <-- start.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/mailnews/base/resources/locale/en-US/mail_mozilla.gif,v
done
Checking in mozilla/mailnews/base/resources/locale/en-US/mail_mozilla.gif;
/cvsroot/mozilla/mailnews/base/resources/locale/en-US/mail_mozilla.gif,v <--
mail_mozilla.gif
initial revision: 1.1
done
Checking in mozilla/mailnews/base/resources/locale/en-US/region.properties;
/cvsroot/mozilla/mailnews/base/resources/locale/en-US/region.properties,v <--
region.properties
new revision: 1.4; previous revision: 1.3
done
Checking in mozilla/mailnews/jar.mn;
/cvsroot/mozilla/mailnews/jar.mn,v <-- jar.mn
new revision: 1.60; previous revision: 1.59
done
OK, checked in. Now let's start making it a really good page :)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 13•23 years ago
|
||
*** Bug 128785 has been marked as a duplicate of this bug. ***
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•