191236 - Freeze nsIWebBrowserFocus and nsIWebBrowserChromeFocus interfaces

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Juan José Mata]

As discussed at the 9/20/02 and 1/24/03 API review meetings these APIs are ready
to be frozen.  Hopefully targetting 1.3 final since this is only a status
comment change.

See here for the details:
http://www.mozilla.org/projects/embedding/apiReviewNotes.html#nsIWebBrowserFocus
http://www.mozilla.org/projects/embedding/apiReviewNotes.html#nsIWebBrowserChromeFocus

Please follow the guidelines outlined in the "How to mark an interface as
FROZEN" at http://www.mozilla.org/projects/embedding/HowToFreeze.html

Nominating topembed from the get-go.

Comment 1

[saari (gone)]

->bryner, should be easy since you have a tree

Comment 2

[Michael Buckland]

Discussed in edt bug triage.  Plussing.

Comment 3

[Juan José Mata]

Brian, do you think we can make these changes (just comments, rights?) in time
for 1.3 final?

Taking the liberty of updating the target milestone for you, and nominating as
blocker for 1.3 ...

Comment 4

[Brian Ryner (not reading)]

Attachment: patch

cleaned up comments and style, and marked as frozen.  I tried to explain some
of the more quirky aspects of activate and deactivate as well.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 114648 [details] [diff] [review]
patch

Chris, can you take a look at the comments I added for activate and deactivate
and make sure they make sense?

Comment 6

[saari (gone)]

Comment on attachment 114648 [details] [diff] [review]
patch

r=saari

Comment 7

[Alec Flett]

Comment on attachment 114648 [details] [diff] [review]
patch

sr=alecf

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 114648 [details] [diff] [review]
patch

Can we get this interface in for 1.3?  Comment changes only.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Um.. how come there was no announcement on n.p.m.embedding or the api-announce
list about the proposed freeze of this interface?

Comment 10

[Juan José Mata]

There was, see the message below:

Return-Path: <[e-mail]>
Received: from netscape.com ([10.169.105.86]) by judge.mcom.com
          (Netscape Messaging Server 4.15) with ESMTP id H95DU902.RFI;
          Wed, 22 Jan 2003 19:32:33 -0800 
Message-ID: <[e-mail]>
Date: Wed, 22 Jan 2003 19:32:24 -0800
From: [e-mail] (Juan Jose Mata)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.2)
Gecko/20021120 Netscape/7.01
X-Accept-Language: en-us, en
MIME-Version: 1.0
Newsgroups: netscape.public.mozilla.embedding,netscape.public.mozilla.porkjockeys
To: Chris Saari <[e-mail]>,
	 Alec Flett <[e-mail]>,
	 Radha Kulkarni <[e-mail]>,
	 John Keiser <[e-mail]>,
	 Brian Ryner <[e-mail]>
CC: Daniel Matejka <[e-mail]>,
	 Judson Valeski <[e-mail]>,
	  [e-mail]
Subject: API review agenda (1/24/03) - Embedding
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Follow up on past Embedding API review meetings.

We'll cover the two APIs listed below on Friday the 24th starting at
1:00pm, Pacific time. If you're in Mountain View, we'll be in the 
Ironsides (B21-1) conference room.  Dial in info:

     Local: 703-265-4200
     Toll free: [phone]

     Scheduled Meeting ID: 1212

--disclaimer--
The list is a simple enumeration of the APIs that we know are being
used by some of our clients.  It does not intend to imply that freezing
of that API is the motivation, but rather that we need to understand why
its use was necessary and whether other interfaces exist now/should be
created to handle the needs, where necessary.
--disclaimer--

If you're on the 'to' list of this mail, your attendance is requested
(though anyone is always welcome). Handouts will not be provided, so if
you're not familiar w/ the interfaces being discussed, please bring your
own printout via printing the idl links below. The living notes document
for the API Review is available at
http://www.mozilla.org/projects/embedding/apiReviewNotes.html

Agenda:
nsIWebBrowserChromeFocus (Chris Saari)
-
http://lxr.mozilla.org/seamonkey/source/embedding/browser/webBrowser/nsIWebBrowserChromeFocus.idl

nsIWebBrowserFocus (Chris Saari)
-
http://lxr.mozilla.org/seamonkey/source/embedding/browser/webBrowser/nsIWebBrowserFocus.idl

Comment 11

[Boris Zbarsky [:bzbarsky]]

Yes, but note the disclaimer in that announcement and the fact that the
_results_ of these meetings are not publicised.  So what happens if you missed
the meeting?

I don't have any strong views on this particular interface, but could we please
carry through on our promise of announcing "this interface is about to freeze"
when it's about to freeze?

Comment 12

[Juan José Mata]

Sure.  The API review notes were updated as advertised, so the information was
indeed available.  The only thing missing was a "go take a look at the review
notes" reminder or a quick recap on the meeting outcome on the same public
aliases.  I'll try to make sure these happen going forward as well.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 114648 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.3

Comment 14

[Brian Ryner (not reading)]

checked in.

Comment 15

[Boris Zbarsky [:bzbarsky]]

jj, my apologies for missing the updating of the API review notes.... and thank
you in advance for those reminders!

Comment 16

[Charles Rosendahl]

Verified