191580 - typeaheadfind accesses sound device on Linux when it's set to just "beep"

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Jeremy M. Dolan]

Gecko/20030125 Phoenix/0.5

When I do a type ahead find, the sound device is accessed. Nothing plays, but I
notice because my OS has to load the audio driver.

I don't see any way to turn this off, but there is a pref set to "beep", which I
guess means it's supposed to use the pc speaker. TAF should avoid forcing the OS
to load a driver if it's not going to actually use sound.

accessibility.typeaheadfind.soundURL is set to "beep", the default.

Comment 1

[Boris Zbarsky [:bzbarsky]]

"beep" means we try to use sound in TAF; but the nsISound impl on Linux may well
be broken....

Comment 2

[Jeremy M. Dolan]

Beep is sound? Why not "true", then...

Anyway, if sound is broken, and I think it is, play shouldn't be attemped, so
drivers and such don't have to be loaded.

And if it's not broken, there should be a global sound pref. I don't want
Mozilla touching my sound card at all.

Comment 3

[Aaron Leventhal]

Prefs -> Advanced -> Keyboard navigation

[ ] Play a sound when the typed text isn't found

There are other bugs on our sound implementation not doing everything it should
on Linux.

Comment 4

[Jo Hermans]

Reporter, is this fixed ?

Comment 5

[Jeremy M. Dolan]

It's not fixed, but it may be a different component causes sound access. It
seems like when I scroll the page now, I get the modprobe errors about sound
modules. Not sure if the TAF code would even fire for e.g. down-arrow.

Comment 6

[timeless]

Attachment: only hang early if we actually plan on playing sounds

Comment 7

[timeless]

*** Bug 221958 has been marked as a duplicate of this bug. ***

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 140447 [details] [diff] [review]
only hang early if we actually plan on playing sounds

Well, I don't really like the API design here, but it is documented that
calling Init is optional, so sr=bryner.

Comment 9

[timeless]

I don't like any part of the api design. but that's neither here nor there.

checked in.

if people care about this they should do some testing. but don't call me, i
don't care. - i'm sorry that this wasn't fixed a while ago, i feel like i wrote
this patch a few months ago.

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 233415 has been marked as a duplicate of this bug. ***

Comment 11

[Jeremy M. Dolan]

Doesn't appear fixed in Firefox 0.8. The first time after system boot that I hit
spacebar to scroll, I get:

kernel: Soundblaster audio driver Copyright (C) by Hannu Savolainen 1993-1996
kernel: sb: Creative SB AWE64 PnP detected
kernel: sb: ISAPnP reports 'Creative SB AWE64 PnP' at i/o 0x220, irq 7, dma 1, 5
kernel: SB 4.16 detected OK (220)
kernel: sb: 1 Soundblaster PnP card(s) found.
modprobe: modprobe: Can't locate module sound-service-0-3

Was this fix seamonkey only? Or is this something else trying to trigger sound.

Comment 12

[timeless]

that's right:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp&rev=FIREFOX_0_8_RELEASE
(FIREFOX_0_8_RELEASE:1.77)

1.81	timeless%mozdev.org	Feb 2 15:12	 	Bug 191580 typeaheadfind accesses sound
device on Linux when it's set to just "beep"
r=biesi sr=bryner

I'm sorry, i don't support branches.

Comment 13

[timeless]

that said, rumor has it there's a chance for a 1.6.1 release. so i'd like to
propose this patch be committed to that branch.