192074 - remove mozilla/mailnews/absync

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

remove mozilla/mailnews/absync

this code was originally added for palm sync, but it's not used by palm sync.

since only ns uses it, we want to move it to the ns tree.

for mozilla, it just adds bloat.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch, and I'll also cvs remove -f mozilla/mailnews/absync

Comment 2

[(not reading, please use [e-mail] instead)]

I'll also have to find out how we package things for Mach-O, so I can make the
right packaging file changes to the ns tree.

this blocks some absync fixes cavin is waiting to land in the ns tree.

Comment 3

[(not reading, please use [e-mail] instead)]

ccarlen tells me that right now, mach o builds are just made by packaging up 
the dist/bin dir.

that should change (see bug #192142), but for now, I don't have to worry about 
it.

Comment 4

[(not reading, please use [e-mail] instead)]

I'll talk to asa about doing this code removal in 1.3 final.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 113651 [details] [diff] [review]
patch, and I'll also cvs remove -f mozilla/mailnews/absync

cavin, addition to this patch, I'll be cvs removing mozilla/mailnews/absync

can you review?

Comment 6

[Cavin Song]

Comment on attachment 113651 [details] [diff] [review]
patch, and I'll also cvs remove -f mozilla/mailnews/absync

r=cavin.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 113651 [details] [diff] [review]
patch, and I'll also cvs remove -f mozilla/mailnews/absync

a=asa (on behalf of drivers) for checkin to 1.3final.

Comment 8

[(not reading, please use [e-mail] instead)]

fixed.

the code has been removed from the mozilla tree (mozilla/mailnews/absync)

I also had to make a change to 
mozilla/build/mac/build_scripts/MozillaBuildList.pm 

Comment 9

[(not reading, please use [e-mail] instead)]

I also removed the following unused files:

mozilla/mailnews/addrbook/src/nsABSyncDriver.cpp
mozilla/mailnews/addrbook/src/nsABSyncDriver.h

and cls had to fix something I forgot in mozilla/allmakefiles.sh

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: patch, more supplimental clean up

Comment 11

[hacker formerly known as [e-mail]]

Comment on attachment 114236 [details] [diff] [review]
patch, more supplimental clean up

r=cls

Comment 12

[(not reading, please use [e-mail] instead)]

ok, I landed the supplimental fix and updated mozilla/tools/module-deps/all.dot
as well. 

Comment 13

[J.J. Enser]

It seems like the mach-o build still has issues with absync. I see the following
errors in today's mach-o build:

creating mailnews/absync/build/Makefile
can't read ./mailnews/absync/build/Makefile.in: No such file or directory
creating mailnews/absync/Makefile
can't read ./mailnews/absync/Makefile.in: No such file or directory
creating mailnews/absync/public/Makefile
can't read ./mailnews/absync/public/Makefile.in: No such file or directory
creating mailnews/absync/src/Makefile
can't read ./mailnews/absync/src/Makefile.in: No such file or directory

reopen?

Comment 14

[hacker formerly known as [e-mail]]

jj, that was fixed by seth's earlier checkin for bug 192907.

Comment 15

[(not reading, please use [e-mail] instead)]

right, this was fixed this morning.

Comment 16

[Ninoschka Baca]

Verified Fixed, by going to lxr.mozilla.org and searching on "absync". I no
longer see paths to "mozilla/mailnews/absync".