192211 - Clean up accessible menu events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When a top level menu is popped open, the menu events should go like this:
MENUSTART
MENUPOPUPSTART

When it's closed:
MENUPOPUPEND
MENUEND

1. The menu events should always be symmetrical
2. There should not be extra unnecessary menu events

Comment 1

[Aaron Leventhal]

Attachment: SetActive() is what causes the menustart/menuend events to fire. Make sure it happens when it is supposed to, and everything works out nicely.

Comment 2

[Aaron Leventhal]

*** Bug 185857 has been marked as a duplicate of this bug. ***

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 113786 [details] [diff] [review]
SetActive() is what causes the menustart/menuend events to fire. Make sure it happens when it is supposed to, and everything works out nicely.

usual caveats about the menu code being fragile, but I think you know the drill
by now.

Comment 4

[Aaron Leventhal]

Comment on attachment 113786 [details] [diff] [review]
SetActive() is what causes the menustart/menuend events to fire. Make sure it happens when it is supposed to, and everything works out nicely.

Need this for work with screen reader vendors.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This scares me a bit at this stage.  How important is this?  Could it wait for
1.4alpha?

Comment 6

[Aaron Leventhal]

> This scares me a bit at this stage.  How important is this?  
> Could it wait for 1.4alpha?

I'm hoping to get this in so I can work with GW Micro over the next month, and
have a working screen reader implementation to show at the March 15 CSUN conference.

The patch is small. I can back it out immediately if it causes any problems with
menus.

Comment 7

[Asa Dotzler [:asa]]

I'm not sure that we have the time or the testing to validate this change on the
1.3 branch. Can you provide the folks you're working with a patched build so we
don't have to take this risk into 1.3? 

Comment 8

[Aaron Leventhal]

checked in

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381