192318 - clean up fix for bug #191817 in msgHdrViewOverlay.js

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

neil's got some ways to clean up the fix I landed for #191817 (don't use eval()
for security reasons)

neil has the patch in his tree, so assigning to him.

Comment 1

[Daniel Veditz [:dveditz]]

Marking secure since the comment and filename gives people enough clues to
create an exploit.

Comment 2

[[e-mail]]

Attachment: Cleanup #1: don't clone the attachment object

Comment 3

[[e-mail]]

Attachment: Cleanup #2: use prototypes to structure code

Comment 4

[[e-mail]]

Attachment: Cleanup #3: Eliminate dofunc helper function

This makes it easier to add additional context menu items, e.g. view source

Comment 5

[[e-mail]]

/me must remember to check these in :-)

Comment 6

[[e-mail]]

Attachment: Updated for bitrot

Based on #3.

Comment 7

[David :Bienvenu]

Comment on attachment 131449 [details] [diff] [review]
Updated for bitrot

sr=bienvenu

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[Daniel Veditz [:dveditz]]

Should this land on the 1.4 branch?

Comment 10

[Mike Kaply [:mkaply]]

This is just cleanup, the security fix is already in, right?

It doesn't apply to 1.4.

Comment 11

[Mike Kaply [:mkaply]]

My understanding is that the security fix is in, this is just cleanup.

Someone correct me if I am wrong.

Comment 12

[Daniel Veditz [:dveditz]]

Removing security flag for this cleanup bug