192352 - ~ns{In,Out}putStreamReadyEvent should check nsIEventQueue::isQueueOnCurrentThread

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Darin Fisher]

a better solution to bug 192196 would involve checking
nsIEventQueue::isQueueOnCurrentThread to see if it is actually ok to release
mNotify on the current thread, instead of leaking when PostEvent fails.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

Attachment: v1 patch (whitespace changes removed)

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 117980 [details] [diff] [review]
v1 patch (whitespace changes removed)

shouldn't this be debug only?

Comment 4

[Darin Fisher]

no, i don't think so.  the "let's just leak this shit" case should never be hit
in real code.  but, otherwise it can definitely be the case that someone
constructs a {In,Out}putStreamEvent and never calls the On{In,Out}putStreamReady
method, which is what causes the event to be posted to the event queue.  if that
method isn't called, then we need to have code to cleanup.  this is that code :-)

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 117980 [details] [diff] [review]
v1 patch (whitespace changes removed)

okay.

Comment 6

[Darin Fisher]

fixed-on-trunk