192755 - Unable to allow popup from a site with a specified port

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[xavier.loup]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.3b) Gecko/20030210
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.3b) Gecko/20030210

The dialog "Popup Exceptions - Allowed Web Sites" is not able to handle
specified ports for websites. 

Reproducible: Always

Steps to Reproduce:
1. In preferences, select Privacy & Security, Popup Windows and choose Suppress
Popups
2. Try to add the site localhost:8080 to the list of the dialog "Popup
Exceptions - Allowed Web Sites" 

Actual Results:  
The site 8080 is added to the list of sites.
The popups from the site localhost:8080 are blocked.

Expected Results:  
The site localhost:8080 should have been added to the list of sites.
The popups from the site localhost:8080 should be allowed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/popupManager.js#348

addPermission() incorrectly trims schemes (as in, it will trim out hosts if
there is a port).

It also assumes that all URIs involved are HTTP....

Comment 2

[xavier.loup]

May be you could change the regexp :
    host.replace(/^\s*([-\w]*:\/*)?/, "");
with :
    host.replace(/^\s*([-:\w]*\/\/*)?/, "")

Works for me ...

Comment 3

[xavier.loup]

cleaner :
    host.replace(/^\s*([-:\w]*\/+)?/, "");

it doesn't solve the proble of the protocol (http, https, ...)

Comment 4

[xavier.loup]

Is it possible to apply the fix ?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Eiffel, if you could attach a patch (see
http://www.gerv.net/software/patch-maker/ for a way to do this without having a
complete Mozilla tree) and request review from "[e-mail]" and
super-review from [e-mail], that would be a good start....

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 195774 has been marked as a duplicate of this bug. ***

Comment 7

[xavier.loup]

Attachment: Patch to allow port in popupManager.js

Comment 8

[xavier.loup]

Comment on attachment 116245 [details] [diff] [review]
Patch to allow port in popupManager.js

Asking for review.

Comment 9

[shliang]

Attachment: i prefer this

Comment 10

[jag (Peter Annema)]

Comment on attachment 116258 [details] [diff] [review]
i prefer this

sr=jag

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 116258 [details] [diff] [review]
i prefer this

r=bzbarsky, then  ;)  (if jag and Shuehan are happy with it...)

Comment 12

[shliang]

resolving