192805 - Page Info Window does not remember previous size

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Obry]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030210
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030210

The "View Page Info" windows no longer remember it's previous size. Each time it
is opened it defaults to one size that is pretty narrow for the content it
displays .

Reproducible: Always

Steps to Reproduce:
Right click on a web page and select "View Page Info"

Actual Results:  
Window to open in it's previous size.

Expected Results:  
Window opens in a default size.

If it's too time consuming to make it remember it's size it would be nice to
make it at least one time wider than it is now so you don't have to resize each
time to view the basic info...

Comment 1

[R.K.Aa.]

.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Looks like this was removed as part of the patch for bug 181764.  Why?

Comment 3

[timeless]

bad merges, db48x wasn't using a real tree w/ real versioning.

Comment 4

[Daniel Brooks [:db48x]]

maybe. either that or I was messing with having it sized based on font size or
something. (there's a bug about it somewhere). Anyway, lemme attach a patch.

Comment 5

[Daniel Brooks [:db48x]]

Attachment: patch

Comment 6

[Daniel Brooks [:db48x]]

Comment on attachment 114177 [details] [diff] [review]
patch

requesting r=/sr=

Comment 7

[timeless]

Comment on attachment 114177 [details] [diff] [review]
patch

i can't find those entities in lxr.

Comment 8

[timeless]

Comment on attachment 114177 [details] [diff] [review]
patch

ok. i dropped 
'window.' when i ran my search. *sigh*.

Comment 9

[Daniel Brooks [:db48x]]

Comment on attachment 114177 [details] [diff] [review]
patch

fixes one of those "doh" kinda things that always seem to slip through. not
critical to anything, but it's certainly nice for it to remeber. pretty low
risk, I wager.

two lines changed, r=timeless, sr=bz
doh=me

thanks,
db48x

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

I guess this bug can be marked NEW.

Comment 11

[Daniel Brooks [:db48x]]

heh, yea. I think it's confirmed. I'll go ahead and accept. 

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 114177 [details] [diff] [review]
patch

a=asa(on behalf of drivers) for checkin to 1.3 final.

Comment 13

[Daniel Brooks [:db48x]]

so, now that I've got a=, could I ask for a checkin? I can't do it my self, if
you'll recall. Thanks

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, marking FIXED.
Checking in pageInfo.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.43; previous revision: 1.42
done

Comment 15

[Daniel Brooks [:db48x]]

verified