193078 - Cookie entries are wiped out by creating a new profile

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Koike Kazuhiko]

Cookie entries are wiped out by creating a new profile.

Steps to reproduce:
(1) Select [Tools]-[Switch Profile] and create a new profile.
(2) Launch with the new profile and quit.
(3) Launch with the old profile and open Cookie Manager dialog.


Build: 2003021108-trunk/Win98

Comment 1

[Darin Fisher]

sounds like we might be missing some profile change notifications in the cookies
code :(

Comment 2

[Anders Åge Larsen]

This should be easy to fix. Its just to do as IE does it, one cookie map for
each profile...

Comment 3

[[e-mail]]

Confirmed by mvl on a recent build.

relevant code is:
http://lxr.mozilla.org/seamonkey/source/extensions/cookie/nsCookieService.cpp#210

No idea what's going on here, probably some subtle bug...

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Using a few printf's, I found out that at
http://lxr.mozilla.org/seamonkey/source/extensions/cookie/nsCookieService.cpp#218
when changing back to the old profile, mDir still contains the path of the
original profile. So that cookie file is updated. The cookies that were there,
are now gone.
So that caching of mDir is the problem.

Comment 5

[Conrad Carlen (not reading bugmail)]

> So that caching of mDir is the problem.

You're right. Caching mDir was put in for bug 158216, so it got broken then. If
mDir is being cached, it simply needs to be reset after the profile changes.

Comment 6

[Conrad Carlen (not reading bugmail)]

I'll take it. I have a patch that I'll be able to test when the rest of my build
finishes.

Comment 7

[Conrad Carlen (not reading bugmail)]

Attachment: patch

mDir shouldn't be cached anyway. It's used infrequently, once per profile
session and, even if it was used frequently, directory service caches
internally anyway.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 114343 [details] [diff] [review]
patch

>-    COOKIE_Write(mDir);
>+    nsCOMPtr<nsIFile> profileDir;
>+    rv = NS_GetSpecialDirectory(NS_APP_USER_PROFILE_50_DIR, getter_AddRefs(profileDir));
>+    if (NS_SUCCEEDED(rv))
>+      COOKIE_Write(profileDir);
>     COOKIE_RemoveAll();

Why not use COOKIE_Write(nsnull) and let COOKIE_Write find the profile? It is
doing that anyway.
And when you do that, you can as well remove the parameter from the prototype
of COOKIE_Write, as all the callers use nsnull as parameter.

Comment 9

[Conrad Carlen (not reading bugmail)]

Attachment: removes dir param from COOKIE_Write()

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 114350 [details] [diff] [review]
removes dir param from COOKIE_Write()

Patch looks good to me.

Comment 11

[Darin Fisher]

Comment on attachment 114350 [details] [diff] [review]
removes dir param from COOKIE_Write()

sr=darin (thanks conrad!)

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 114350 [details] [diff] [review]
removes dir param from COOKIE_Write()

Requesting approval.
This is a dataloss bug when switching profiles. The risk of the patch are
pretty small (just removing the caching of an item)

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 114350 [details] [diff] [review]
removes dir param from COOKIE_Write()

a=asa (on behalf of drivers) for checkin to 1.3 final

Comment 14

[Conrad Carlen (not reading bugmail)]

Fixed. Thanks Michiel - you handed the fix to me on a platter :-)

Comment 15

[Josh Birnbaum]

*** Bug 193531 has been marked as a duplicate of this bug. ***