193611 - Os/2 - www.oldversion.com crashes Mozilla in mozjs.dll

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[rasta m0n]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.3b) Gecko/20030211
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.3b) Gecko/20030211

Download page on www.oldversion.com crashes Mozilla in mozjs.dll

Reproducible: Always

Steps to Reproduce:
1.go to www.oldversion.com, click Realplayer on the sidebar
2.on the next page click Realplayer 8
3.crash in mozjs.dll happens after the next page loads

Actual Results:  
crash/browser closes/etc

Expected Results:  
download file

Comment 1

[Oliver Klee]

Over to JavaScript Engine as a first guess.

Comment 2

[Matthias Versen [:Matti]]

wfm with win2k build 20030216..

Comment 3

[Mike Kaply [:mkaply]]

taking - appears to be os/2 only.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Fix

Need to set MAX_INTERP_LEVEL to 30 for OS/2

Comment 5

[Robert Ginda]

Comment on attachment 114630 [details] [diff] [review]
Fix

r=rginda.  Like phil said over mail, we probably need to set this for the
standalone shell too.  It looks to me like js/src/config.mk has no provision
for os/2 though.  Could be that nobody cares about Makefile.ref on os/2.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Better patch

I talked to brendan about this and he said if I come up with a good value for
OS/2, I should just put it in the code.

I did some initial investigation and found that 250 is a good number for OS/2.

I put the #ifdef in and also modified the existing #ifdef to be more clear. I
hope this is OK.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 114814 [details] [diff] [review]
Better patch

Ok by me.

/be

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 114814 [details] [diff] [review]
Better patch

OK, just to confuse things, I asked rginda to r= on IRC and I'm taking
brendan's r as an sr if that is OK.

Looking for approval for 1.3final since this is a crasher on OS/2.

Comment 9

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 10

[Phil Schwartau]

checkin Verified -