Closed
Bug 193637
Opened 23 years ago
Closed 23 years ago
Cookie logging is reversed
Categories
(Core :: Networking: Cookies, defect)
Core
Networking: Cookies
Tracking
()
RESOLVED
FIXED
People
(Reporter: dwitte, Assigned: dwitte)
Details
Attachments
(1 file)
|
1.77 KB,
patch
|
timeless
:
review+
darin.moz
:
superreview+
dbaron
:
approval1.3+
|
Details | Diff | Splinter Review |
It looks like the patch that did some refactoring to create COOKIE_AddCookie had
a minor mistake in it.
if (NS_SUCCEEDED(rv)) { // log a failure }
huh?? tsk danm ;)
Had me confused for a few minutes while staring at a cookie log...
|
Assignee | |
Comment 1•23 years ago
|
||
r/sr = darin?, for 1.3f?
|
|
Assignee | |
Updated•23 years ago
|
Attachment #114629 -
Flags: superreview?(darin)
Attachment #114629 -
Flags: review?(darin)
Attachment #114629 -
Flags: review?(darin) → review+
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 114629 [details] [diff] [review]
patch
sr=darin
Attachment #114629 -
Flags: superreview?(darin) → superreview+
|
|
||
Comment 3•23 years ago
|
||
Comment on attachment 114629 [details] [diff] [review]
patch
requesting drivers approval for this trivial patch. would be good to have sane
cookie logging in the tree for 1.3 final. thx!
Attachment #114629 -
Flags: approval1.3?
Attachment #114629 -
Flags: approval1.3? → approval1.3+
|
||
Comment 4•23 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•