Closed
Bug 193918
Opened 23 years ago
Closed 22 years ago
pipe should better utilize current segment (rollback write cursor whenever read cursor == write cursor)
Categories
(Core :: XPCOM, defect, P5)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
(Keywords: perf)
Attachments
(1 file, 2 obsolete files)
|
4.42 KB,
patch
|
darin.moz
:
review+
dougt
:
superreview+
|
Details | Diff | Splinter Review |
pipe should better utilize current segment. in other words, we should rollback
the write cursor to the beginning of the current segment whenever all data in
the pipe has been read. this adjustment can only happen from
nsPipe::GetWriteSegment. this should help reduce heap churn, especially over
slower connections. i've also noticed some cases where not rolling back the
write cursor results in many small reads from the network. see the log files in
bug 193017 for instance.
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Updated•22 years ago
|
Severity: normal → minor
Priority: -- → P5
Target Milestone: mozilla1.4alpha → mozilla1.4beta
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
revised comments.
Attachment #118375 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #119318 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•22 years ago
|
||
bz and i talked about this some over irc and came up with something better.
the old patch would have busted OS/2 (symptom of arena allocated buffer
segments).
Attachment #119318 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #119339 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•22 years ago
|
Attachment #119318 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 4•22 years ago
|
||
Comment on attachment 119339 [details] [diff] [review]
v1.2 patch
bz gave r= over IRC
Attachment #119339 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #119339 -
Flags: superreview?(dougt)
|
||
Comment 5•22 years ago
|
||
Comment on attachment 119339 [details] [diff] [review]
v1.2 patch
i would flip the test around so that you test against zero first.
r=dougt.
Attachment #119339 -
Flags: superreview?(dougt) → superreview+
|
|
Assignee | |
Comment 6•22 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•