194082 - Update Mac Desktop Get Info string to 1.4a after Mozilla 1.3 branch is cut

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[lpham]

This is land on the trunk after MOZILLA_1_3_BRANCH is cut

Need to update
mozilla/xpfe/bootstrap/nsMacVersion.r
mozilla/xpfe/bootstrap/macbuild/Contents/Info.plist

Comment 1

[Tracy Walker [:tracy]]

Attachment: patches for Desktop get info string

paches in the follow files:
mozilla/xpfe/bootstrap/macbuild/Contents/Info.plist
mozilla/xpfe/bootstrap/nsMacVersion.r

Comment 2

[lpham]

Comment on attachment 115395 [details]
patches for Desktop get info string

look good r=lpham

Comment 3

[J.J. Enser]

Comment on attachment 115395 [details]
patches for Desktop get info string

sr=jj.

Comment 4

[Tracy Walker [:tracy]]

patches checked in...marking fixed

Comment 5

[Tracy Walker [:tracy]]

/mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.string

version update as follows:
CFBundleGetInfoString = "Mozilla 1.3b,  1998-2003 The Mozilla Organization"

to

CFBundleGetInfoString = "Mozilla 1.4a,  1998-2003 The Mozilla Organization"

I used KHexEdit on linux to edit the binary file.

Comment 6

[Tracy Walker [:tracy]]

hmmm...I don't think that edit worked quite right.  the copywrite symbol is missing.

Comment 7

[Tracy Walker [:tracy]]

JJ, I cannot submit a diff for binary file so I removed 1.3b to 1.4a inside 
mozilla/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/
InfoPlist.strings

CFBundleGetInfoString = "Mozilla 1.3b, © 1998-2003 The Mozilla Organization";

to 

CFBundleGetInfoString = "Mozilla 1.4a, © 1998-2003 The Mozilla Organization";

(Note: I'm using BBEdit to edit this file)

Let me know if it looks ok to you.  Thanks.

Comment 8

[J.J. Enser]

r=jj for the change to .../English.lproj/InfoPlist.strings

Tracy, the reason why we cannot diff these .plist files is because they have a
unicode 2-byte header which makes cvs think it's a binary file. Bummer, but I
don't think there's anything we can do about it.

Comment 9

[J.J. Enser]

I'm sorry please disregard my last comment (#8). What I wrote is true for the
branch, but the reality is that we don't need this value in the English
"overlay", so we shoudl just REMOVE the line

   CFBundleGetInfoString = "Mozilla 1.3b, © 1998-2003 The Mozilla Organization";

from InfoPlist.strings and the value for CFBundleGetInfoString will
automatically be picked up from mozilla/xpfe/bootstrap/macbuild/Contents/Info.plist

Comment 10

[Tracy Walker [:tracy]]

checked in with
CFBundleGetInfoString = "Mozilla 1.3b,  1998-2003 The Mozilla Organization";
removed

Comment 11

[lpham]

Verified with the trunk build

Comment 12

[J.J. Enser]

Loan, you need to verify this against the installed product, not against the
source tree.
This is not just my preference, but the way bugs have always been verified.
That's also what makes the verification process different from the review process.

If you don't know how to do this, I'll be happy to show you on your Mac.

Comment 13

[lpham]

Thanks for your offer JJ.
Verified against installed product.