194226 - Crash with helper applications

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Kaply [:mkaply]]

We've discovered a crash when you add a helper application that has the same
name as a previous one. In trashing the crash, we trashed it to this change by me:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=plevent.c&root=/cvsroot&subdir=mozilla/xpcom/threads&command=DIFF_FRAMESET&rev1=1.31&rev2=1.32

Surprisingly, for reasons we don't understand, changing OS/2 to send a message
instead of destroying the window does bad things.

We experimenting with posting the message, using WM_DESTROY instead of WM_CLOSE,
etc. etc., but nothing worked.

So the correct fix is to go back to the old way.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix

Going back to the old way.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 115012 [details] [diff] [review]
Fix

remove the lines commented out (we have cvs history for that).	r=

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 115012 [details] [diff] [review]
Fix

I think this comes under sr=blizzard since plevent.c has large chunks of
#ifdeffed platform specific code and this is one of them.

Looking for 1.3 approval - this is OS/2 only and is a crasher.

Thanks

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 115012 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to 1.3

Comment 5

[Mike Kaply [:mkaply]]

Fix checked in.