194488 - crash if i click on any mail or news article :-/

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030222
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030222

I am using an homemade build, based on 21st february sources + CVS updates until
02/22 - 01:17 configure.in patch.

Here is the "about:buildconfig" datas :

about:buildconfig

Build platform
target
i686-pc-cygwin

Build tools
Compiler 	Version
cl 	
cl 	

Configure arguments
--enable-calendar --enable-crypto --disable-installer --disable-tests
--disable-debug --enable-optimize --enable-strip


Reproducible: Always

Steps to Reproduce:
1.Build a new mozilla
2.go to mailnews.
3.click on a mail to read it.

Actual Results:  
Mozilla is crashing. VC++ said it is an access violation in gklayout.dll

Expected Results:  
reading mail !

clean install ; clean profile.

Comment 1

[Frederic Bezies]

Modifying summary, because crash also happens in news :-/

Have to downgrade to my previously working mozilla !

Do I have to make a debug build in order to help more ?

Comment 2

[Bernard Alleysson]

I'm seeing this too, ie crash when I try to read any news.mozilla.org post

access violation reading location 0xffffffff :

	gklayout.dll!nsXULElement::GetBindingParent(nsIContent * * aContent=0x0012e628)
 Line 4419 + 0xa	C++
 	gklayout.dll!nsBindingManager::GetOutermostStyleScope(nsIContent *
aContent=0x01ac2ac8, nsIContent * * aParent=0x0012e678)  Line 1317	C++
 	gklayout.dll!nsBindingManager::WalkRules(nsIStyleSet * aStyleSet=0x01a9a510,
int (nsISupports *, void *)* aFunc=0x60494030, RuleProcessorData *
aData=0x00000000)  Line 1367	C++
 	gklayout.dll!StyleSetImpl::FileRules(int (nsISupports *, void *)*
aCollectorFunc=0x60494030, RuleProcessorData * aData=0x00000001)  Line 1084	C++
 	gklayout.dll!StyleSetImpl::ResolveStyleFor(nsIPresContext *
aPresContext=0x0168e940, nsIContent * aContent=0x00988c28, nsStyleContext *
aParentContext=0x01c46784)  Line 1183	C++
 	gklayout.dll!nsPresContext::ResolveStyleContextFor(nsIContent *
aContent=0x01ac2ac8, nsStyleContext * aParentContext=0x01c46784)  Line 949	C++
 	gklayout.dll!FrameManager::ReResolveStyleContext(nsIPresContext *
aPresContext=0x0168e940, nsIFrame * aFrame=0x01c74018, nsIContent *
aParentContent=0x00000000, int aAttrNameSpaceID=0x00000000, nsIAtom *
aAttribute=0x009e7b38, nsStyleChangeList & aChangeList={...}, nsChangeHint
aMinChange=0x0000000e, nsChangeHint & aResultChange=0x01c74018)  Line 1741 + 0xe	C++
 	gklayout.dll!FrameManager::ComputeStyleChangeFor(nsIPresContext *
aPresContext=0x0168e940, nsIFrame * aFrame=0x01c74018, int
aAttrNameSpaceID=0x00000000, nsIAtom * aAttribute=0x009e7b38, nsStyleChangeList
& aChangeList={...}, nsChangeHint aMinChange=0x0000000e, nsChangeHint &
aTopLevelChange=0x6054b2d0)  Line 2036	C++
 	gklayout.dll!nsCSSFrameConstructor::AttributeChanged(nsIPresContext *
aPresContext=0x01c74018, nsIContent * aContent=0x01ac2ac8, int
aNameSpaceID=0x0000000e, nsIAtom * aAttribute=0x01d4d7d0, int
aModType=0x00000000, nsChangeHint aHint=0x612510b2)  Line 10746	C++

Comment 3

[Frederic Bezies]

Is this related to bugfix for bug 114713 ?

In comment #2, there is :

- nsCSSFrameConstructor -> 
- FrameManager -> mozilla/ layout/ base/ public/ nsIFrameManager.h ?
- StyleSet -> mozilla/ layout/ base/ public/ nsIStyleSet.h ?

So, is bugfix for 114713 guilty here ?!

Comment 4

[Bernard Alleysson]

now this works for me with trunk 2003022210

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The crash from the checkin for bug 114713 that I fixed this morning
(nsCSSFrameConstructor.cpp, revision 1.818, was a crash I noticed while clicking
on a news message.  So I think I've fixed this, although it might be nice if
someone (bryner?) reviews the patch.

Marking fixed.

Comment 6

[Frederic Bezies]

Bug seems to be dead now. It was really a pain-in-the-ass !

When I saw your new version of nsCSSFrameConstructor.cpp on Tinderbox, I think
it was fixed, but I had to wait because of some build bustage.

Thanks a lot !