194528 - Add accesskeys to Open Location

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[piers]

Add accesskeys to File -> Open Location in Navigator.

Comment 1

[piers]

Attachment: Add accesskeys to Open Location

Comment 2

[:deanis74]

Comment on attachment 115251 [details] [diff] [review]
Add accesskeys to Open Location

>+      <label value="&enter.label;" control="dialog.input" accesskey="&enter.accesskey;"/>

>+        <label value="&openWhere.label;" accesskey="&openWhere.accesskey;" control="openAppList"/>

It would be nice to keep the attributes listed in the same order.  I think most
of the time we've been tacking accesskey on at the end, haven't we?  Other than
that, looks good.  r=me with that change

Comment 3

[piers]

Attachment: Add accesskeys to Open Location

How do i carry over "review+"?

Comment 4

[piers]

Actually, Dean, it seems to usually go directly after the "label" (or "value")
attribute. (just looked at a few other files e.g for preferences)

value, accesskey, control|command

What would you prefer?

Comment 5

[:deanis74]

We should be consistent with other files.  To carry over an r=, just set it to
plus by yourself and make a comment that you're carrying over <name>'s review.

Comment 6

[piers]

Going with the original patch which has the accesskey after the label.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 115251 [details] [diff] [review]
Add accesskeys to Open Location

sr=dmose

Comment 8

[:deanis74]

checked in

Comment 9

[sairuh (rarely reading bugmail)]

vrfy'd fixed on win2k and linux rh8.0 with 2003.02.24 comm trunk bits.