194531 - Add accesskeys to profile select/manage dialog

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[piers]

Add accesskeys to profile select/manage dialog.

(Tools -> Switch Profile or mozilla -ProfileManager)

Comment 1

[piers]

Attachment: Add accesskeys to profile manager

Notes:

-<!ENTITY	     workoffline.label	   "Work Offline">
-<!ENTITY	     manageprofiles.label  "Manage Profiles">
This aren't used anywhere

+<!ENTITY	     offlineState.label    "Work offline">
+<!ENTITY	     autoSelectLastProfile.label    "Don't ask at startup">
Should use paragraph capitalisation

Comment 2

[:deanis74]

Comment on attachment 115253 [details] [diff] [review]
Add accesskeys to profile manager

looks good.  r=me

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 115253 [details] [diff] [review]
Add accesskeys to profile manager

sr=dmose

Comment 4

[:deanis74]

checked in

Comment 5

[piers]

*** Bug 194858 has been marked as a duplicate of this bug. ***

Comment 6

[Grace Bush]

verified mozilla build 2003022404

Comment 7

[Jessie Li]

Hi Piers, 

1. Why you change "Work Offline" to "Work offline". I think the second will be
better. You can see File->Work Offline instead of Work offine.

2. You didn't add accesskeys to "Use Profile" button in Select User Profile dialog.

3. ./mozilla -P to pop up Select User Profile dialog, "Start" button has no
accesskey.

My 3 suggestions, hope it can help.

Comment 8

[piers]

Hi Jessie,

1. Changed to "Work offline" (lower case "o") because checkboxes should have 
   paragraph capitalization (menu items use title capitalization).

2. I think i didn't add an accesskey to "Use Profile" because it is the default
   button (i.e. you can just press enter to activate it). Is this right? -- 
   perhaps not...

3. As above.