194602 - Clean up print preview toolbar

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[piers]

Print preview bar needs some cosmetic love.

Comment 1

[piers]

Attachment: Clean up print preview toolbar

This patch addresses the following issues with the print preview toolbar:
1. Make the seperators visible in modern;
2. Remove the extra seperator before close;
3. Add accesskeys and tooltips where relevant;
4. Make it so it is easy to add/remove items from the toolbar in future -- at
the moment there has to be exactly the right amount of elements for stuff to
work!

Comment 2

[piers]

cc'ing rods@netscpae for printing and aaronl@netscape for access.

Comment 3

[piers]

Note: the toolbar has fewer items on platforms that we don't support printing on 
(just unix maybe?) -- you can simulate it on other platforms by changing on line
213:

if (!canPrint)
to
if (canPrint)

Comment 4

[timeless]

Comment on attachment 115320 [details] [diff] [review]
Clean up print preview toolbar

it's an improvement, but there are still 10 other bugs that could be fixed
eventually, please :)

Comment 5

[timeless]

Comment on attachment 115320 [details] [diff] [review]
Clean up print preview toolbar

oh whoops. don't give anonymous content id's and don't use getElementById.
sorry

Comment 6

[piers]

Ok, i obviously didn't know how to do this right then. I don't know how you would
not give stuff id's and still have accesskeys because you need a controlid.

Marking wontfix (bugs can be opened for specific stuff later if other people want)

Comment 7

[piers]

Attachment: Clean up print preview toolbar v2

Take 2.... :)

Comment 8

[piers]

Lets see if this is better... :)

Comment 9

[piers]

Attachment: Clean up print preview toolbar v2.1

Little mistake.

Comment 10

[kinmoz]

Comment on attachment 115517 [details] [diff] [review]
Clean up print preview toolbar v2.1

Looks ok to me. sr=[e-mail]

Does whoever owns the print UI in mozilla need to look this over?

Comment 11

[piers]

Attachment: Clean up print preview toolbar v2.2

Comment 12

[piers]

Attachment: Clean up print preview toolbar v2.3

Comment 13

[piers]

Comment on attachment 115625 [details] [diff] [review]
Clean up print preview toolbar v2.3

Neil wanted to change "childNodes[2]" (etc) to be firstChild/LastChild to
follow the surrounding code. Also fixed the title of the custom prompt (which
never worked before).

Comment 14

[kinmoz]

Comment on attachment 115625 [details] [diff] [review]
Clean up print preview toolbar v2.3

sr=[e-mail]

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpfe/communicator/resources/content/printPreviewBindings.xml;
/cvsroot/mozilla/xpfe/communicator/resources/content/printPreviewBindings.xml,v
 <--  printPreviewBindings.xml
new revision: 1.17; previous revision: 1.16
done
Checking in xpfe/communicator/resources/locale/en-US/printPreview.dtd;
/cvsroot/mozilla/xpfe/communicator/resources/locale/en-US/printPreview.dtd,v 
<--  printPreview.dtd
new revision: 1.4; previous revision: 1.3
done