194636 - Forwarding binary message produces invalid message

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Kai Engert [:KaiE:]]

This is a regression introduced with bug 161488.

To reproduce this bug, you need a specially prepared message, that is usually
not produced by mail agents, but is valid (and might be sent by other mail agents).

For example, a message, where the single content is an image.
I can send such a message to anybody who wants to test this behaviour, let me know.


Steps to reproduce:
- receive a message that is (e.g.) of content type image/gif
- forward this message to yourself
- receive the message and look at it

Actual behaviour:
- the received message does not display the image
- when doing view source, raw binary data is displayed

Expected behaviour:
The image should get forwarded as base64 and should display fine when received.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch v1

This patch appears to fix the problem for me.
I've tested a variety of messages and all seems to be fine.

The idea of the patch is: When doing forwarding as attachment and having
output_format set to Decrypt-Only, when dealing with an mimeExternalObject, do
not allow to decode (be it base64, uue, etc.), but instead pass through the
external object directly.

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 115333 [details] [diff] [review]
Patch v1

Can you please review?

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 115333 [details] [diff] [review]
Patch v1

sr=sspitzer, but if he as time (he may not), can you get ducarroz to review?

my only request would be before you check in, please add a comment to the code
like:

// for forwarding binary messages, see bug #194636

(no need for a new patch)

Comment 4

[Jean-Francois Ducarroz]

Comment on attachment 115333 [details] [diff] [review]
Patch v1

R=ducarroz

Comment 5

[(not reading, please use [e-mail] instead)]

thanks for the review, ducarroz.  (I know you are busy with other things)

Comment 6

[Kai Engert [:KaiE:]]

Patch checked in, marking fixed.

Comment 7

[Kai Engert [:KaiE:]]

Comment on attachment 115333 [details] [diff] [review]
Patch v1

Suggesting to fix this regression for the 1.3 release.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 115333 [details] [diff] [review]
Patch v1

a=asa (on brhalf of drivers) for checkin to 1.3 branch. Please land this ASAP
and put fixed1.3 in the status whiteboard. Thanks.

Comment 9

[Kai Engert [:KaiE:]]

Fix checked in to 1.3 branch.