195494 - Startup time rose 200ms - 10% Ts performance regression

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Simon Fraser [no longer active]]

Startup time spiked at around 13:00 today. We need to figure out why.

Comment 1

[Doug Turner (:dougt)]

to me.  

Comment 2

[Doug Turner (:dougt)]

*** Bug 195496 has been marked as a duplicate of this bug. ***

Comment 3

[Doug Turner (:dougt)]

It could be a couple thing:

I added a new feature that allows dependent libraries to be loaded for each
component. Now we check to see if the xpcom component library require additional
libraries to be loading prior calling LoadLibary on the component.  Right now
these lists of depend libraries are empty.

I also change the data structure which keeps track of component libaries from
being an array to being a hashtable.  It could be that creating the hash key for
each entry isn't as fast as we would like -- certianly slower than just
appending linking another node on a list.

I will see what i can do....

Comment 4

[Doug Turner (:dougt)]

I am pretty sure the cost is the hashtable.  I am going to revert this change
tonight to verify.

As soon as we start using the nsINativeComponentLoader interface to populate
dependent libraries, the hash table may be required.

Comment 5

[Doug Turner (:dougt)]

so, the hashtable and key construction wasn't the problem.  

Comment 6

[Simon Fraser [no longer active]]

Didn't you add some new linkage when this regression happened?

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

*** Bug 195703 has been marked as a duplicate of this bug. ***

Comment 8

[Doug Turner (:dougt)]

backed out.

Comment 9

[Doug Turner (:dougt)]

changes were backed - found the block of code that caused this it no longer
executes at startup when using a local GRE build.  I am still investigating the
root cause of the perf of this block of code:

            nsCOMPtr<nsIFile> greDirectory;
            NS_GetSpecialDirectory(NS_GRE_COMPONENT_DIR,
getter_AddRefs(greDirectory));
            nsCOMPtr<nsILocalFile> lFile = do_QueryInterface(greDirectory);
            if (!lFile)
                goto out;

            lFile->GetPersistentDescriptor(str);

Comment 10

[Simon Fraser [no longer active]]

Startuptime regressed again today. Mac OS X went from ~4800-5400, Linux from
3200->3550, and 1450->1600.

Comment 11

[Doug Turner (:dougt)]

Checking in xptiManifest.cpp;
/cvsroot/mozilla/xpcom/reflect/xptinfo/src/xptiManifest.cpp,v  <--  xptiManifest.cpp
new revision: 1.26; previous revision: 1.25
done


backed out.  

Comment 12

[Cathleen]

Ts numbers are backed down again on tboxes
looks like this is is fixed.

Comment 13

[Doug Turner (:dougt)]

closing since i backed out a long time ago.