195881 - Buttons should not be able to draw as active when they are disabled

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Brian Ryner (not reading)]

If you have a disabled button, the current GTK nsITheme implementation will
still allow it to draw in the pressed-in state.  Steps to reproduce:

1. Switch to classic skin
2. File -> Open File...
3. Don't click on any files, but click the OK button in the filepicker

Expected result: the button does not appear to depress, since it's disabled
Actual result: the button depresses

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

This looks rather large, but it encompasses some additional cleanup.  I changed
the widget state to be a series of flags rather than a struct, and I changed
the tab state flags to use the kEnumValue style rather than ENUM_VALUE.

The actual _fix_ is in several places where gtkdrawing.c acts on the "active"
state flag, it needs to also check the disabled flag.  I thought about putting
the logic in nsNativeThemeGtk, but decided that the nsNativeThemeGtk code
should fill in all the information that it can obtain, and then leave it up to
the drawing implementation how to interpret it.

Comment 2

[Christopher Blizzard (:blizzard)]

Should this be in here?  Does this break our error handling?

-  gdk_flush();
+  //  gdk_flush();

Also, this is going to break the crap out of the patch that I just made in bug
174471 because it adds real ints to the state struct.

Comment 3

[Brian Ryner (not reading)]

Attachment: less invasive patch, updated to the trunk

Comment 4

[jag (Peter Annema)]

Comment on attachment 123735 [details] [diff] [review]
less invasive patch, updated to the trunk

sr=jag

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 123735 [details] [diff] [review]
less invasive patch, updated to the trunk

r=blizzard

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 123735 [details] [diff] [review]
less invasive patch, updated to the trunk

a=sspitzer,asa

Comment 7

[Brian Ryner (not reading)]

checked in.