196433 - use /usr/bin/perl instead of /usr/bonsaitools/bin/perl

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P2)

Description

[Diego Biurrun]

Bugzilla uses a non-default Perl path specific to the Bugzilla installation at
b.m.o and maybe a handful of others.  The vast majority of installations use the
default Perl from /usr/bin/perl and have to adapt their setup through a sed/perl
expression or a symlink.  This is not acceptable since clearly the bonsaitools
bunch is in the minority.  You guys at b.m.o should be adapting your Bugzilla
setups, not we poor souls using Bugzilla outside b.m.o.

This issue has been discussed at least in bug 172598 and bug 44202 before but
none of them went so far as I in requesting to revert the current behavior.  Bug
44659 proposes to create a Makefile that adapts the Perl path, but this is
really only a workaround.  Bugzilla should work out of the box on common setups,
tweaking should only be necessary for special setups

If this gets OKed I will gladly come up with a patch to do it.  I'm not doing it
up front because I expect some discussion to take place.

Comment 1

[Dave Miller [:justdave]]

I wholeheartedly agree. :-)

Last time we considered this, mozilla.org made veiled threats at us if we even
thought about changing it.  It would make their life more difficult when they
have to upgrade, and they kinda gave us life... :)

However, mozilla.org's Bugzilla is now running on its own machine which
mozilla.org themselves now have a little more control of than they used to (AOL
IC used to @!%&*@!% about changing anything on it), and there's different people
in charge of babysitting it now (Myk :)

So what do you think, Myk?  Would we get into trouble if we made /usr/bin/perl
on Mothra point at the Perl Bugzilla's actually using?

I notice there is no perl at /usr/bin/perl currently, so it's not like we'd be
breaking an existing perl by doing it.

Comment 2

[Dave Miller [:justdave]]

OK, after a short conference with Myk in IRC, a symlink to the Perl that
Bugzilla is using has been placed at /usr/bin/perl on Mothra, and we'll babysit
it this weekend.  If nothing breaks (cron jobs or what have you), we'll probably
consider that to be approval from mozilla.org to change the #! in Bugzilla. :)

Comment 3

[Dave Miller [:justdave]]

I've posted a heads-up to mozilla-webtools and developers mailing lists that
we'll be changing it in the next few days (just in case anyone has more than one
perl on their machine and /usr/bonsaitools/bin/perl isn't pointing at
/usr/bin/perl).

Once it's had time to distribute I'll go ahead and make the change in CVS.

In the long-term picture our installation process (checksetup.pl or whatever it
evolves into) will take care of rewriting the path to whatever perl you use to
run the installer script, but this will do much nicer in the mean time :)

Comment 4

[Jacob Steenhagen]

Attachment: Patch - shebang, tests, and docs

Any adverse reactions yet?

Comment 5

[Tobias Burnus]

Hurray - finally I'll be able to really see which files are changed when doing a
cvs up date!

UPGRADING-pre-2.8, docs/makedocs.pl  and contrib/mysqld-watcher.pl
still contain the "#!/usr/bonsaitools/bin/perl" line - even after applying the
patch (attachment 118547 [details] [diff] [review]).

Otherwise the patch looks ok. (Does one really call the line "shebang"?)

Comment 6

[Dave Miller [:justdave]]

There have been no adverse reactions on mothra.

Let's do it.

Jake, your patch has issues per Tobias.  Fix it :)

Comment 7

[Jacob Steenhagen]

Attachment: Patch v2

OK, I fixed it!
:)

Comment 8

[Jacob Steenhagen]

-> me

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 118585 [details] [diff] [review]
Patch v2

>--- runtests.sh	10 Nov 2002 03:50:31 -0000	1.6
>+++ runtests.sh	26 Mar 2003 22:49:35 -0000

>-/usr/bonsaitools/bin/perl runtests.pl ${TEST_VERBOSE}
>+/usr/bonsaitools/bin/perl runtests.pl $*
       ^^^^^^^^^^^

Ahem.  :)

Comment 10

[Jacob Steenhagen]

Attachment: Patch v2.1

Doh!

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 118591 [details] [diff] [review]
Patch v2.1

works for me.

Lots of references in the docs still, but they're outside of sgml, so hopefully
they'll go away next time you recompile the docs. :)

Comment 12

[Dave Miller [:justdave]]

<imitation who="M&Ms minis">
Do it!  Do it!  So it!
</imitation>

Comment 13

[Jacob Steenhagen]

This touches so many files that I won't copy/paste the output of cvs commit, but
it's in.

Yes, most of the bonsaitools references in the docs/html folder will go away
next time I compile them... There will still be a couple references for
historical value :)