196474 - pop-up icon should appear in status bar before "about popup blocking" appears

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Remove user_pref("privacy.popups.firstTime", false); from prefs.js.
2. Visit http://www.aol.com/ .

Result: A dialog appears explaining what the status bar icon means.  Once you
close the dialog, the status bar icon appears.

Expected: The status bar icon should appear before the dialog appears.

I'm using Phoenix 03/04 on Windows XP.  I haven't tested whether this bug is
also present in Mozilla, because I don't know how to reset pop-up blocking in
Mozilla.

Comment 1

[Sébastien Delahaye]

OS -> All

Comment 2

[Mike Connor [:mconnor]]

-> taking

easily enough fixed, just moving some code around

Comment 3

[Mike Connor [:mconnor]]

Attachment: patch

Comment 4

[Jesse Ruderman]

setTimeout("displayPageReportFirstTime();",50);
should be
setTimeout(displayPageReportFirstTime, 50);

I prefer the second syntax because the second syntax is more efficient and
because the first syntax can lead to security holes like bug 87980 if you pass
untrusted string parameters without escaping them.

Comment 5

[Mike Connor [:mconnor]]

Attachment: patch that addresses Jesse's comments

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 131532 [details] [diff] [review]
patch that addresses Jesse's comments

at this rate, noririty's review queue will be fricking huge :)

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

-> 0.9

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 131532 [details] [diff] [review]
patch that addresses Jesse's comments

going to shorten the timeout, patch coming in a bit

Comment 9

[Mike Connor [:mconnor]]

Attachment: pch sez 10 is enough

Comment 10

[Pierre Chanial]

Comment on attachment 140133 [details] [diff] [review]
pch sez 10 is enough

I changed my mind. this delay is somewhat arbitrary and for some slow machine,
the icon may not appear.

This dialog should not be modal, from the gnome human interface guidelines:
"Use an application modal window only if allowing interaction with other parts
of the application while the window is open could cause data loss or some other
serious problem."
you should just replace "modal" with "dependent" in
displayPageReportFirstTime()

Comment 11

[Mike Connor [:mconnor]]

Attachment: use dependent instead of modal dialog

this works too

Comment 12

[Mike Connor [:mconnor]]

Comment on attachment 142537 [details] [diff] [review]
use dependent instead of modal dialog

maybe we should do this in other places too?

Comment 13

[Pierre Chanial]

Comment on attachment 142537 [details] [diff] [review]
use dependent instead of modal dialog

> maybe we should do this in other places too?
Mike, it would be great if you could review the modality of our dialogs !

Comment 14

[Mike Connor [:mconnor]]

fix checked in 02/28/2004 18:41

Comment 15

[José Jeria]

*** Bug 238647 has been marked as a duplicate of this bug. ***