196602 - no bookmarks in xlib builds

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Xlib, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Neither the personal toolbar nor the bookmarks menu contain any bookmarks in an
xlib build (current trunk).

This is probably related to the Xlib port claiming to implement XRemote, but not
really supporting it:
from configure.in:
   3047 xlib)
   3048     MOZ_ENABLE_XLIB=1
   3049     MOZ_ENABLE_XREMOTE=1
   3050     TK_CFLAGS='$(MOZ_XLIB_CFLAGS)'
   3051     TK_LIBS='$(MOZ_XLIB_LDFLAGS)'

From an assertion at startup:
WARNING: couldn't get widget helper service, file
../../../../../xpfe/components/xremote/src/XRemoteService.cpp, line 369

Especially:
JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIXRemoteService.addBrowserInstance]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://navigator/content/navigator.js :: Startup :: line 592"  data: no]

This causes the javascript in navigator.js to be aborted, which causes the
bookmarks to not load. This is similar to bug 196468.

-> The solution is to remove the MOZ_ENABLE_XREMOTE=1 line from the above
mentioned part of configure.in.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: stop claiming to support xremote

Comment 2

[Benjamin Smedberg]

Comment on attachment 145927 [details] [diff] [review]
stop claiming to support xremote

I'm fine with this, but blizzard should have a look.

Comment 3

[Christopher Blizzard (:blizzard)]

Comment on attachment 145927 [details] [diff] [review]
stop claiming to support xremote

I thought that the xlib code did support xremote, but if it doesn't this is OK
with me (and it's the right way to do it.)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1337; previous revision: 1.1336
done

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 145927 [details] [diff] [review]
stop claiming to support xremote

this patch only affects build using the xlib toolkit (i.e. not those using
gtk), and is very low risk

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 145927 [details] [diff] [review]
stop claiming to support xremote

a=asa (on behalf of drivers) for checkin to 1.7

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on 1.7 branch