196683 - Remove infinite recursion loop check in XPC_WN_Helper_NewResolve

Status: VERIFIED FIXED

(Core :: XPConnect, defect, P2)

Description

[David Bradley]

The check at
http://lxr.mozilla.org/mozilla/source/js/src/xpconnect/src/xpcwrappednativejsops.cpp#911
is no longer needs. The JS engine avoids this.

Comment 1

[David Bradley]

Attachment: Removes the recursion check

This removes the recursion checks.

Comment 2

[David Bradley]

To 1.5

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 120570 [details] [diff] [review]
Removes the recursion check

r=[e-mail]

/be

Comment 4

[David Bradley]

Comment on attachment 120570 [details] [diff] [review]
Removes the recursion check

Looking for an sr, will try and get this into 1.4b since have a patch and an
r=, and have a little time left before the freeze

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 120570 [details] [diff] [review]
Removes the recursion check

sr=jst

Comment 6

[David Bradley]

Attachment: Revised, only removes the check for resolve callbacks only

I was a little over eager on removing some of the recursion checks. The one in
XPC_WN_OnlyIWrite_PropertyStub is not only a recursion check, but a check for
being called from the resolve callbacks. In that situation it allows the
addition of the property by XPConnect, but prevents others.

So, the patch is similar, unfortunately doesn't remove as much code as before.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 120881 [details] [diff] [review]
Revised, only removes the check for resolve callbacks only

sr=jst

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 120881 [details] [diff] [review]
Revised, only removes the check for resolve callbacks only

r=[e-mail] -- can you enlighten me about where the get-property is
in an xpconnect resolve hook?

Also, please add diff -p to your .cvsrc file, it'll help label context hunks
with function or method names.

/be

Comment 9

[David Bradley]

Not sure if I understand what you are asking. A couple of get properties occur
when the XPCNativeMember's Resolve gets called via GetValue, and it creates a
new function, but nothing involving the currently resolving property. If a
scriptable helper is involved, then pretty much anything could happen.

The problem I was having in the first patch was that add-property hook was
getting called as a result of creating the property from within the resolve hook
via the XPConnect DefineProperty function.

Comment 10

[David Bradley]

Patch checked in

Comment 11

[Phil Schwartau]

Checking verified -

Comment 12

[David Bradley]

*** Bug 80368 has been marked as a duplicate of this bug. ***