196766 - Different accesskeys for View | HTML Source, and Insert | HTML..

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Andrea]

This is the proposal for a patch checkin.
This pach is risk free, and required from the localizers.

Since its low low low risk, it would be nice have it checked in 1.3.

The reason for this patch:
Specifically, two menu items in Composer share the same accesskey in two
different menu (View | HTML Source, and Insert | HTML..). This is bad (btw, not
only in the specific case..) since different languages might either have
different letters "occupied" in different menu, or translate differently sligtly
different menu item names in English sharing the same name (hence requiring
different accesskeys).

Comment 1

[Andrea]

Attachment: patch for /editor/ui/composer/content/editorOverlay.xul

Attached patch for editorOverlay.xul, to pick a different accesskey for View |
HTML Source, and Insert | HTML.. menu items.

Comment 2

[Kathleen :Brade]

can we get a contextual diff in the future?

Insert HTML is not the same thing as View HTML Source.  They should not share
the same accesskey entity.  I expect to see a change in a dtd file to add a new
accesskey (if indeed they are using the same accesskey entity)

Comment 3

[Andrea]

> can we get a contextual diff in the future?

Sorry, -badly- I assumed any of the 3 formats might have do the job.

> Insert HTML is not the same thing as View HTML Source. They should not share
> the same accesskey entity.

Thank you for confirming.

> I expect to see a change in a dtd file to add a new
> accesskey (if indeed they are using the same accesskey entity)

No need for this. We already have a _dedicated_ entity defined in
http://lxr.mozilla.org/seamonkey/source/editor/ui/composer/locale/en-US/editorOverlay.dtd#166
[Resume]
 current situation:
Two defined etities, and one of these used two times.
 desired situation:
Take the "orphaned" entity form editorOverlay.dtd in vice of the
second call of HTMLSourceMode.accesskey.

Comment 4

[Martijn Ras]

*** Bug 218392 has been marked as a duplicate of this bug. ***

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Yes, I understand this bug and confirm it.
reporter : thanks for detecting it.

Can someone in the Cc list handle this please ?

Comment 6

[[e-mail]]

Attachment: Patch updated for bitrot and diffed -u

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 138709 [details] [diff] [review]
Patch updated for bitrot and diffed -u

r=[e-mail]

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 138709 [details] [diff] [review]
Patch updated for bitrot and diffed -u

rs=me.

/be

Comment 9

[[e-mail]]

Fix checked in.