196959 - Disable xpinstall under Mac OSX

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Sean Su]

Since xpinstall is not really working under Mac OSX, we should disable it for
1.3f until bug 195788 is fixed.

Comment 1

[Sean Su]

Attachment: patch v1.0

This will simply disable xpinstall under Mac OSX.  No dialog will show up
requesting the user for installation previliges.  It will simply quit xpinstall
with UNEXPECTED_ERROR.

Comment 2

[Chris Casciano]

Would this patch disable *all* addons including those working in 1.3RC OS X
builds like the ones mentioned in bug 195788 and themes? If so I think a relnote
and an attempt to contact authors of known failing XPI installers is in order
rather then the drastic over compensation here.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 116906 [details] [diff] [review]
patch v1.0

sr=dveditz

Is there a bug on re-enabling XPInstall on MacOSX when the other bugs are
fixed?

Comment 4

[Daniel Veditz [:dveditz]]

never mind my last comment, obviously bug 195788 covers it because you won't be
able to mark that fixed without backing this out.

Comment 5

[Chris Casciano]

question 2: is the intention here to only disable it on the 1.3 branch or the
the trunk too?

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 116906 [details] [diff] [review]
patch v1.0

a=asa (on behalf of drivers) for checkin to 1.3 branch.

Comment 7

[Sean Su]

patch checked in to 1.3 branch only.

This will disable all xpinstall functionality from within the browser.

Comment 8

[Chris Casciano]

I'm not happy with this in the least (I'll probably stick to an RC w/o this
patch for quite some time... or at least until i switch back to nightlies or
Camino off the trunk stabalizes) and I suspect they'll be plenty of dupes/bugs
filed on this as 1.3 goes out... on that note 2 questions:

(a) Shouldn't Hardware be Mac and not PC so theres some chance of people finding
this?

(b) Isn't a major & last minute functionality regression like this worthy of at
least a rel note?

Comment 9

[Sean Su]

changed hardware to Macintosh.

asa also said he was going to update the release notes about this change.

Comment 10

[Joe Infla]

*** Bug 197493 has been marked as a duplicate of this bug. ***

Comment 11

[Grace Bush]

verified

Comment 12

[Mark Knipfer]

In this newsgroup (netscape.netscape7.windows) see this message thread:

From: Mark Knipfer <[e-mail]>
Newsgroups: netscape.netscape7.windows
Subject: .XPI files not installing
Date: Sat, 15 Mar 2003 13:30:50 -0500
Message-ID: <b4vr1v$[e-mail]>

about the Mozilla 1.3 .XPI file installation and download problems.

Comment 13

[Sean Su]

Patches to bug 186088 and bug 195109 have both been merged to the 1.3 branch. 
This should be enough to get xpinstall under OSX running again.

So I've unfixed the patch attached to this bug on the 1.3 branch.