197079 - Status bar doesn't display "Stopped" when stop button is clicked

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P5)

Description

[Tracy Walker [:tracy]]

this has been around for quite some time (2002-10-11).  See bugscape bug 20546
for original citing in comment 11. That bug was tracking the throbber not
stopping in NS.  I added this behavior to it, but should have opened a new bug
here.  Again this isn't critical.  Just possibly confusing to those paying
attention to the status bar.  Stop button does stop the page load.

-browse a page that takes some time to load
-click the stop button

the browser status bar will usually display something regarding connecting
too... or transfering data from..., etc. It should display "Stopped". On some
occassions, if I click stop just after attempting to load the page, the expected
"Stopped" status is displayed. This does, however, seem quite random. My best
attempts to reproduce the successful "Stopped" status has been to goto
www.netscape.com and immediately click the stop button.

cc'ng those in the bugscape bug

Comment 1

[Asa Dotzler [:asa]]

This is a fairly high visibility UI feedback regression. Is there some other
duplicate bug somewhere covering this (and its dupes)? It seems odd to me that
such a visible regression would go uncommented on for so long.

Comment 2

[Doug Turner (:dougt)]

Asa|Tracy

Are you seeing this?  I tried a few common sites that i could not reproduce 
with windows 1.4a.

Comment 3

[Tracy Walker [:tracy]]

I have been seeing this since I first reported it in bugscape 20546.  It is
still present on all platforms.  Please read my original comments for how to
reproduce this reliably.

Comment 4

[Asa Dotzler [:asa]]

I can reproduce this consistently at netscape.com or slashdot or any
sufficiently large page. After about 1/4th of the page is loaded I press the
stop button and the status bar continues to display "Connecting to
cdn.netscape.com..." or "Connecting to images.slashdot.com..."

Comment 5

[jag (Peter Annema)]

Regular load of slashdot.org:

|Connecting to slashdot.org...|||Stopped
|Waiting for slashdot.org...|||Stopped
|Transferring data from slashdot.org...|||Stopped
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from images2.slashdot.org...|||
|Transferring data from pagead.googlesyndication.com...|||
|Transferring data from images.slashdot.org...|||
Document http://slashdot.org/ loaded successfully
||||Done

Interrupted load of slashdot.org:

|Connecting to slashdot.org...|||Done
|Connecting to slashdot.org...|||Done
|Waiting for slashdot.org...|||Done
|Waiting for slashdot.org...|||Done
|Transferring data from slashdot.org...|||Done
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from slashdot.org...|||
|Transferring data from images2.slashdot.org...|||
|Transferring data from pagead.googlesyndication.com...|||
|Transferring data from images.slashdot.org...|||
Error loading URL http://slashdot.org/ : 804b0002
||||Stopped
|Transferring data from images.slashdot.org...|||Stopped
|Connecting to images.slashdot.org...|||Stopped

Comment 6

[jag (Peter Annema)]

Those dumps came from this piece of code in nsBrowserStatusHandler.js:

  updateStatusField : function()
  {
    dump(this.overLink + "|" + this.status + "|" + this.jsStatus + "|" +
this.jsDefaultStatus + "|" + this.defaultStatus + "\n");
    var text = this.overLink || this.status || this.jsStatus ||
this.jsDefaultStatus || this.defaultStatus;

Comment 7

[jag (Peter Annema)]

-> darin who figured out what's going on and knows how to fix it.

Comment 8

[Darin Fisher]

patch on the way...

Comment 9

[Darin Fisher]

Attachment: v1 patch

Comment 10

[Darin Fisher]

Comment on attachment 122240 [details] [diff] [review]
v1 patch

patch is real simple.  we just suppress status/progress notifications after a
channel has been canceled.  previously we would only suppress status
notification occuring after OnStopRequest, but i think that is wrong. 
OnDataAvailable is normally suppressed after Cancel, and so should all other
necko events other than OnStopRequest.	this patch makes it so.

Comment 11

[jag (Peter Annema)]

Comment on attachment 122240 [details] [diff] [review]
v1 patch

sr=jag

Comment 12

[Doug Turner (:dougt)]

Comment on attachment 122240 [details] [diff] [review]
v1 patch

i am concerned about the the policy change|enforcement wrt onStatus.  pleaes
add some comments in nsIProgressEventSink stating that these events will not
fire before AsyncOpen or after cancel/onStopRequest

Comment 13

[Darin Fisher]

Attachment: v1.1 patch

same thing, but i've fixed up the comments in nsIProgressEventSink.idl ... man
that is an old file!!  had a lot of broken old comments dating back to '98 ;-)

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 122263 [details] [diff] [review]
v1.1 patch

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 122240 [details] [diff] [review]
v1 patch

clearing a request, this is an obsolete patch

Comment 16

[Darin Fisher]

fixed-on-trunk

Comment 17

[Tracy Walker [:tracy]]

verified fixed with commercial trunk builds:

linux 2003-05-02-05-trunk
mac 2003-05-02-03-trunk

Comment 18

[Tracy Walker [:tracy]]

this has returned.  seen with recent builds.  
-click "Stop" button while a large page loads

sometimes the status displays stop. but more often it displays some in progress
message.  sometimes "done" is displayed even though the page still has obviously
loading to do.

Comment 19

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 20

[Doug Turner (:dougt)]

trace: what recent builds (i am using 1.4rc1) and what url can you repro this on?

Comment 21

[Doug Turner (:dougt)]

trace, this wfm. 

Comment 22

[Tracy Walker [:tracy]]

use a page that takes a few moments to load.  I use home.netscape.com.  wait for
images to begin to appear, then click the Stop button. Done or some progress
message is displayed.  Stop will appear if you click Stop at home.netscape.com
before anything begins to appear.

reopening... this is present on all platforms on trunk and branch builds

Comment 23

[Doug Turner (:dougt)]

Attachment: simple test case

simple test case that show the problem. 

unzip.
load test.html.
hit stop.
note the status bar.

Comment 24

[Doug Turner (:dougt)]

During a load of a frameset, if that load is canceled while frames are still
being loaded the result of the frameset load -- not the children loads -- will
be reported.  
  
I can reproduce this problem in 1.3, 1.4a, 1.4b.  Tracy tells me he can
reproduce this problem in Netscape Communicator 4.8 and in Microsoft Internet
Explorer.

I am not sure we should fix this for 1.4.  

Comment 25

[David G King]

If the fix is trivial, then it should be in 1.4 (there's nothing like having
bragging rights over IE). But, if it is a major fix, then 1.5a would be a better
target.

Comment 26

[Doug Turner (:dougt)]

pushing out milestone.  I am tempted to future.

Comment 27

[Doug Turner (:dougt)]

darin.

Comment 28

[Bogdan Stroe]

Is this the same as bug 114497?

Comment 29

[Tracy Walker [:tracy]]

They are similar bugs.  The other bug mentions "aborted" status. This bug has
been long fixed though.  The status correctly reflects a stopped page load.