197485 - Remove [GS]etTransparentColor from gfxIImageFrame

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

SetTransparentColor has only one caller.
GetTransparentColor has none.

-> I'd like to remove them.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[ArronM (:paper)]

Comment on attachment 117280 [details] [diff] [review]
patch

good riddance :)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 117280 [details] [diff] [review]
patch

Hi tor - could you super-review this removal of two unneeded functions? it also
saves 4 bytes per gfxImageFrame and a bit of code during gif loading.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in gfx/idl/gfxIImageFrame.idl;
/cvsroot/mozilla/gfx/idl/gfxIImageFrame.idl,v  <--  gfxIImageFrame.idl
new revision: 1.11; previous revision: 1.10
done
Checking in gfx/src/shared/gfxImageFrame.cpp;
/cvsroot/mozilla/gfx/src/shared/gfxImageFrame.cpp,v  <--  gfxImageFrame.cpp
new revision: 1.22; previous revision: 1.21
done
Checking in gfx/src/shared/gfxImageFrame.h;
/cvsroot/mozilla/gfx/src/shared/gfxImageFrame.h,v  <--  gfxImageFrame.h
new revision: 1.6; previous revision: 1.5
done
Checking in modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp,v  <-- 
nsGIFDecoder2.cpp
new revision: 1.50; previous revision: 1.49
done