197666 - <ab[Edit|New]CardDialog.xul>: Convert <window class="dialog"> to <dialog>

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Sebastian Späth]

By converting abNewCardDialog and abEditCardDialog from <window...> to
<dialog...> we save some hand rolled functions (like the keyhandling for
VK_ENTER VK_ESCAPE) and remove the dependency to the global dialogOverlay.xul.

Furthermore, the <OK> <Cancel> buttons will show up in the right order if one
does the "sidebar on the right side"-customization trick
(http://mozilla.org/unix/customizing.html). They are reversed now...

Comment 1

[Sebastian Späth]

Attachment: convert to <dialog>

One last question. I included the global.css in both files and left the
inclusion of messenger/skin/dialogs.css in there:
<?xml-stylesheet href="chrome://global/skin/global.css" type="text/css"?>
<?xml-stylesheet href="chrome://messenger/skin/dialogs.css" type="text/css"?>

However I could take both out (using modern theme) without any obvious
regressions. Are they both needed or should they be taken out?
(If yes, I will submit a new patch)

Comment 2

[Sebastian Späth]

forgot to assign to me...

Comment 3

[Sebastian Späth]

Attachment: buttons are centered ("buttonpack=center") now again...

Comment 4

[[e-mail]]

Comment on attachment 117395 [details] [diff] [review]
buttons are centered ("buttonpack=center") now again...

-<?xml-stylesheet href="chrome://messenger/skin/dialogs.css" type="text/css"?>
-

and

+<?xml-stylesheet href="chrome://global/skin/global.css" type="text/css"?>
 <?xml-stylesheet href="chrome://messenger/skin/dialogs.css" type="text/css"?>

I don't think you meant these.

Comment 5

[[e-mail]]

To clarify: you should have exactly one stylesheet if possible;
I don't have a problem with using global.css but do check dialog.css first
in case there are some specific rules for that dialog.

Comment 6

[Sebastian Späth]

Attachment: now only using global.css (dialogs.css is unneccessary in this case as far as I can see)

Comment 7

[[e-mail]]

Comment on attachment 117383 [details] [diff] [review]
convert to <dialog>

Cancelling review on obsolete patch.

Comment 8

[Stefan Borggraefe]

Comment on attachment 117577 [details] [diff] [review]
now only using global.css (dialogs.css is unneccessary in this case as far as I can see)

I just tested this patch with the current trunk. It still applies und works.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in addrbook/resources/content/abCardOverlay.js;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abCardOverlay.js,v  <--  ab
CardOverlay.js
new revision: 1.46; previous revision: 1.45
done
Checking in addrbook/resources/content/abEditCardDialog.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abEditCardDialog.xul,v  <--
  abEditCardDialog.xul
new revision: 1.17; previous revision: 1.16
done
Checking in addrbook/resources/content/abNewCardDialog.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abNewCardDialog.xul,v  <--
 abNewCardDialog.xul
new revision: 1.31; previous revision: 1.30
done

Comment 10

[Stefan Borggraefe]

*** Bug 187361 has been marked as a duplicate of this bug. ***