197874 - Land NSS 3.8 on the Mozilla trunk.

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Wan-Teh Chang]

We would like to land NSS 3.8 on the Mozilla trunk
before mozilla 1.4alpha.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch for build/package/rpm

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch for embedding

Comment 3

[Wan-Teh Chang]

Attachment: Proposed patch for xpinstall

Comment 4

[Wan-Teh Chang]

Comment on attachment 117566 [details] [diff] [review]
Proposed patch for build/package/rpm

Blizzard, could you review my patch for build/package/rpm?

I am going to add a new NSS file, libsoftokn3.chk, which
needs to be installed in the same directory as libsoftokn3.so.

I found three files under build/package/rpm that contain
libsoftokn3.so.  I made the obvious changes to two of them
in this patch.	I did not change one of them,
/build/package/rpm/SOURCES/mozilla-nspr-packages.patch,
because it's not obvious what it is and whether I need to
change it.  Please advise.  Thanks.

Comment 5

[Wan-Teh Chang]

Attachment: Proposed patch for build/package/rpm v2

Comment 6

[Wan-Teh Chang]

Attachment: Proposed patch for build/package/rpm v2

Attached the wrong patch earlier.  This one is correct.

Comment 7

[Wan-Teh Chang]

Comment on attachment 117572 [details] [diff] [review]
Proposed patch for build/package/rpm v2

In this patch I attempted to change mozilla-nspr-packages.patch
as well.  Blizzard, please review it.  Thanks.

Comment 8

[Wan-Teh Chang]

cls, would you be able to review my patches for embedding and
xpinstall or suggest the appropriate reviewers?

I am going to add three new NSS files.
1. libsoftokn3.chk/softokn3.chk.
2. libfreebl_hybrid_3.chk.
3. libfreebl_pure32_3.chk.

All platforms have the first one.  Only 32-bit Solaris
SPARC and HP-UX PA-RISC have the second and third ones.

These *.chk files need to be installed in the same
directory as the corresponding shared libraries/DLLs
(libsoftokn3.so/softokn3.dll, libfreebl_hybrid_3.so,
and libfreebl_pure32_3.so).

Comment 9

[hacker formerly known as [e-mail]]

dougt & ssu would be better candidates to review those patches.

Comment 10

[Sean Su]

Comment on attachment 117567 [details] [diff] [review]
Proposed patch for embedding

this looks good.
r=ssu

Comment 11

[Sean Su]

Comment on attachment 117568 [details] [diff] [review]
Proposed patch for xpinstall

r=ssu

Comment 12

[Doug Turner (:dougt)]

all of these above changes seam fine to me.  ooc, what is a chk file?

Comment 13

[Wan-Teh Chang]

Thank you very much for reviewing my patches right away.

These .chk files are essentially the checksums of the
corresponding NSS "softoken" shared libraries.

How do I test my changes to embedding and xpinstall?
After my "make -f client.mk" command is done, where are
the installers and how do I test them?  (I assume that
there are a GRE installer and a Mozilla installer.)

Comment 14

[Christopher Blizzard (:blizzard)]

Comment on attachment 117572 [details] [diff] [review]
Proposed patch for build/package/rpm v2

>+ bin/defaults/messenger/mailViews.dat
>  

Should this be in here?

Also, I don't mind updating these packages files after you land your new NSS
version.  I don't mind playing catch-up.  If you just want to leave this to me,
it's OK with me.

Comment 15

[Kai Engert [:KaiE:]]

Wan-Teh, the installers are not built by default, they must be built manually in
a separate step. See http://www.mozilla.org/build/distribution.html

One important detail is that building the installers don't work with a separate
object dir build. Only an intree build seems to work.

Comment 16

[Sean Su]

[Win32 only]

To test embedding (via it's installer), you have to do the following:
 * from embedding\config run 'make'.  This will deliver the files to the dist
area so the installer build process can pick them up.
 * after that's done, go to xpinstall\wizard\windows\builder and run 'perl
build_mfcembed.pl'.  This will build the actual mfcembed installer to test
embedding.

This will build mfcembed installer to dist\inst_mfcembed.

To build mozilla's installer, do the following:
 * from xpinstall\wizard\windows\builder, run 'perl build.pl'.

This will build the mozilla installer to dist\install.

Kai is correct, the build process does not support objdir, yet.  That's bug 162079.

Comment 17

[Wan-Teh Chang]

Comment on attachment 117572 [details] [diff] [review]
Proposed patch for build/package/rpm v2

Marked the build/package/rpm patch obsolete.  I opened
bug 198051 and will let Blizzard take care of updating
the rpm package files after I land NSS 3.8.

Comment 18

[Wan-Teh Chang]

The Win32 installer of my test build is in my Unix
home directory: /u/wtc/tmp/mozilla-win32-installer.exe.
On the Netscape network, you can fetch this file using
ftp from any Unix machine.

Brent, John, do you have cycles to install and test
this build today?

Comment 19

[Wan-Teh Chang]

Here is the information required by the Mozilla landing tool
(http://komodo.mozilla.org/planning/mozilla-patch-landing-tool.html).

1. The benefit of the NSS 3.8 upgrade is for Mozilla to stay
current with NSS releases and to reduce the need for the NSS
team to back port bug fixes to the NSS branch that Mozilla is
using.

2. Most of the changes will be in mozilla/security/coreconf
and mozilla/security/nss.  However, both API and binary
compatibilities will be maintained, so there will be no changes
to the C and C++ files in Mozilla.  There will be some makefile
changes in PSM (mozilla/security/manager), embedding, and
xpinstall to install the new .chk files in NSS 3.8 that must be
installed in the same directory as the corresponding "softoken"
shared libraries.

3. NSS 3.8 depends on NSPR 4.3, which Mozilla is already using.
No other development tasks depend on NSS 3.8.

4. Basic work is completed and I'm ready for help in testing.

Comment 20

[Wan-Teh Chang]

Experimental Builds

I can provide Linux and Mac OS X experimental builds upon
request.  (See comment 18 for the Win32 experimental build.)

I have tested the Linux, Mac OS X, and Win32 experimental
builds.

Testing Needs

SSL: visit http://www.etrade.com/ or log in on your bank account.

S/MIME: send a signed and encrypted email to yourself and see if
you can decrypt it and verify the signature.

Regression Tracking

Please use this bug as the tracking bug for all the regressions
that surface in experimental build testing.

Comment 21

[Wan-Teh Chang]

I landed NSS 3.8 and checked in both patches today.

Comment 22

[John Unruh]

Verified per wtc's comments.