197927 - upgrade nagging on the mozilla start page doesn't work for nightly builds

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Michael Lefevre]

the script detects nightlies by looking for "+" on revisions - that hasn't been
used for a while, so the script thinks everything is a milestone.  not too
tragic, but it does mean that anyone with a nightly that's more than 14 days old
will get prompted to download the latest milestone.  e.g. someone with a 1.4a
nightly from 15 days ago will be prompted to move to 1.3 final.

I guess the script will need to do something like checking for the "+" (for
older nightlies), and then assuming anything more recent than whenever the +s
were dropped is a nightly unless it matches the buildIDs of the milestones.

(leaving assigned to Gerv for the moment, but I might have a go at a patch
myself at some point...)

Comment 1

[Michael Lefevre]

having thought about this a bit more, I'm not sure it's feasible to do this the
way I was thinking. to tell nightlies from milestones using the builddate, you
would need a list of the build dates of all milestones after July 2002 (the last
one to have '+' revision on nightlies seems to the 1.1a+ builds).

I was imagining that would mean finding a managable list of build dates, but
having tried to look some up, it's occurred to me that the build dates can be
different for different platforms, and then of course there are debian, redhat,
etc packages, so there will be a large collection of build dates for each milestone.

maybe the way to go is to dump the milestone/nightly detection and just offer
milestone builds to everyone? or offer nightlies and milestones to everyone?
views anyone?

Comment 2

[Gervase Markham [:gerv]]

asa, leaf: is there any easy way in recent builds of telling milestone releases
from nightlies using just the user agent?

Gerv

Comment 3

[Michael Lefevre]

Gerv - I asked that question on IRC. The answer is that is no easy way - the UA
strings are not changed for releases any more, so all the nightly builds leading
up to a release and the release itself are identical except for the build id. :(

IIRC timeless said he had a version of this script that he'd done some work on
lying around somewhere...

Comment 4

[Bill Mason]

Fixed by the new code in bug 209537.  If your build is >2 weeks old, the text will
suggest getting the newest milestone if there is a new one, or a new nightly
build (with appropriate warnings about using nightlies).

Comment 5

[Michael Lefevre]

v