198004 - Broken links in search-db.rdf

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Andras Timar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; hu-HU; rv:1.4a) Gecko/20030317
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; hu-HU; rv:1.4a) Gecko/20030317

PAGE: Search database  file:///F|/Mozilla/1.4a-night/helpqa/help/search-db.rdf  
BAD LINKS: 
1. file:///F|/Mozilla/1.4a-night/helpqa/help/register_help.html  (, Error: Not
found (F:\Mozilla\1.4a-night\helpqa\help\register_help.html)) 
2. file:///F|/Mozilla/1.4a-night/helpqa/help/icq_help.html  (, Error: Not found
(F:\Mozilla\1.4a-night\helpqa\help\icq_help.html)) 
3. file:///F|/Mozilla/1.4a-night/helpqa/help/im_help.html  (, Error: Not found
(F:\Mozilla\1.4a-night\helpqa\help\im_help.html)) 

Please remove all references from the search database to im_help.html,
icq_help.html and register_help.html.

4. file:///F|/Mozilla/1.4a-night/helpqa/help/cs_priv_prefs_popup.html  (, Error:
Not found (F:\Mozilla\1.4a-night\helpqa\help\cs_priv_prefs_popup.html)) 
5. file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#cotterSDX 
(link, Error: Undefined Anchor) 
6. file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#ian_oeschgerSDX
 (link, Error: Undefined Anchor) 
7.
file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#information_designSDX
 (link, Error: Undefined Anchor) 
8.
file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#jatin_billimoriaSDX
 (link, Error: Undefined Anchor) 
9.
file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#jennifer_mooreSDX
 (link, Error: Undefined Anchor) 
10. file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#john_gorhamSDX
 (link, Error: Undefined Anchor) 
11.
file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#laura_krietemeyerSDX
 (link, Error: Undefined Anchor) 
12.
file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#robin_foster_clarkSDX
 (link, Error: Undefined Anchor) 
13.
file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#steve_rudmanSDX 
(link, Error: Undefined Anchor) 
14. file:///F|/Mozilla/1.4a-night/helpqa/help/cs_nav_dialogs.html#writersSDX 
(link, Error: Undefined Anchor) 
15.
file:///F|/Mozilla/1.4a-night/helpqa/help/page_info_help.html#viewing_P3P_policySDX
 (link, Error: Undefined Anchor) 


Reproducible: Always

Steps to Reproduce:

Comment 1

[Ian Oeschger (gone)]

accepting

Comment 2

[R.J. Keller]

I'll post a patch for this if no one else is working on it. This is a bug that
has been very annoying to me and would love to fix it.

Comment 3

[R.J. Keller]

Attachment: Patch 1

Removes dead entries (mostly AOL, ICQ stuff). This also removes stuff from
Pop-up blocker help file. Shouldn't Pop-up blocker help file be there? It's
there in NS7.

Comment 4

[R.J. Keller]

Attachment: Patch 1.1

Decided to keep the Pop-up Search info in there for now. Bug 188159 should fix
that problem.

This patch also fixes problems with mail/news.

Comment 5

[R.J. Keller]

oeschger,

I changed chrome://help/locale/page_info_help.html#viewing_P3P_policySDX to
chrome://help/locale/page_info_help.html#pageinfo_security. Do you think that
this is a appropriate change or should I remove it altogether?

Comment 6

[Ian Oeschger (gone)]

Comment on attachment 128869 [details] [diff] [review]
Patch 1.1

r=oeschger. looks great. should have done this more completely myself eons ago.

Comment 7

[R.J. Keller]

oeschger - could you check this in for me? Don't have CVS access :)

Comment 8

[R.J. Keller]

Let's try and get this on the 1.4 branch.

Advantages: Removes references to AOL/Netscape stuff that shouldn't be there in
the first place. This will prevent users from getting results in the Help Search
to help topics that do not exist (because they are only in Netscape).

Risk: There's no real risk.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 128869 [details] [diff] [review]
Patch 1.1

a=asa (on behalf of drivers) for checkin to the 1.4 branch. Who can land this
(and quickly)?

Comment 10

[Ian Oeschger (gone)]

Actually--just a note here--this file was serving for both mozilla and the
commercial browser. Part of this patch is to make a copy of the current rdf file
and put it in the commercial tree, build it there to overwrite the scrubbed
mozilla version. 

The use of this file in NS (and the discreetness of these terms) was why they
have persisted in this mozilla file. Happy to fork at this point, though.

Comment 11

[Ian Oeschger (gone)]

just checked this in.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 128869 [details] [diff] [review]
Patch 1.1

a=asa (on behalf of drivers) for checkin to 1.5beta.

Comment 13

[Ian Oeschger (gone)]

FIXED. Just checked in.

Comment 14

[Daniel Wang]

Keller, I found at least four broken entries:
  IM
  jatin billimoria
  information design
  writers

Should I reopen this bug or just wait for bug 219825 to fix everything?

Comment 15

[R.J. Keller]

well, when bug 219825 is fixed, this won't matter anymore ;)

Comment 16

[Daniel Wang]

v